linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXv+5HVBP31H2hr8BuAy-4jNkS-T12L_mdmPSCV2po1FnO81g@mail.gmail.com>
Date: Tue, 8 Oct 2024 14:45:22 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: Macpaul Lin <macpaul.lin@...iatek.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org, Seiya Wang <seiya.wang@...iatek.com>, 
	Tinghan Shen <tinghan.shen@...iatek.com>, Chunfeng Yun <chunfeng.yun@...iatek.com>, 
	Alexandre Mergnat <amergnat@...libre.com>, Bear Wang <bear.wang@...iatek.com>, 
	Pablo Sun <pablo.sun@...iatek.com>, Macpaul Lin <macpaul@...il.com>, 
	Sen Chu <sen.chu@...iatek.com>, Chris-qj chen <chris-qj.chen@...iatek.com>, 
	MediaTek Chromebook Upstream <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy

On Tue, Oct 8, 2024 at 1:35 PM Macpaul Lin <macpaul.lin@...iatek.com> wrote:
>
> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
> The error message was:
>   t-phy@...30000: 'power-domains' does not match any of the regexes:
>     '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> Fix this issue by dropping 'power-domains' of u3phy1 node.

You should also mention why this fix is correct from a hardware viewpoint,
i.e. why removing the power domain won't break the device.

> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index ade685ed2190..1c6f08dde31c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1920,7 +1920,6 @@ u3phy1: t-phy@...30000 {
>                         #address-cells = <1>;
>                         #size-cells = <1>;
>                         ranges = <0 0 0x11e30000 0xe00>;
> -                       power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
>                         status = "disabled";
>
>                         u2port1: usb-phy@0 {
> --
> 2.45.2
>