linux-kernel - Re: [PATCH v4 RESEND] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2410080855470.20286@cbobk.fhfr.pm>
Date: Tue, 8 Oct 2024 08:57:44 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Stuart Hayhurst <stuart.a.hayhurst@...il.com>
cc: linux-input@...r.kernel.org, Benjamin Tissoires <bentiss@...nel.org>, 
    Christophe JAILLET <christophe.jaillet@...adoo.fr>, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 RESEND] HID: corsair-void: Add Corsair Void headset
 family driver

On Mon, 9 Sep 2024, Stuart Hayhurst wrote:

> Introduce a driver for the Corsair Void family of headsets, supporting:
>  - Battery reporting (power_supply)
>  - Sidetone setting support
>  - Physical microphone location reporting
>  - Headset and receiver firmware version reporting
>  - Built-in alert triggering
>  - USB wireless_status
> 
> Tested with a Void Pro Wireless, Void Elite Wireless and a Void Elite Wired
> 
> Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@...il.com>

Thanks a lot for working on this! I have one small nit:

[ ... snip ... ]
> +config HID_CORSAIR_VOID
> +	tristate "Corsair Void headsets"
> +	depends on USB_HID
> +	select POWER_SUPPLY
> +	help
> +	Support for Corsair Void headsets.
> +
> +	Supported devices:
> +	- Corsair Void headsets
> +

As we alreay have general CONFIG_HID_CORSAIR, I think it'd make sense for 
this driver to be encapsulated under this config option as well (it'd also 
follow the general practice of HID subsystem, that the drivers are divided 
per vendor) -- i.e. link hid-corsair-void into the final hid-corsair.ko 
whenever CONFIG_HID_CORSAIR is selected.

Would you be willing to make that small change, and resubmit for final 
merge?

Thanks,

-- 
Jiri Kosina
SUSE Labs