[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6849d647-0240-4d3b-8f35-e4e65397e389@web.de>
Date: Tue, 8 Oct 2024 08:32:32 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Zhu Jun <zhujun2@...s.chinamobile.com>, linux-sound@...r.kernel.org,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Heiko Stübner <heiko@...ech.de>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Nathan Chancellor <nathan@...nel.org>,
Uwe Kleine-König <u.kleine-koenig@...libre.com>,
Weidong Wang <wangweidong.a@...nic.com>
Subject: Re: [PATCH] ASoC: codecs: aw88399: Correct error handling in
aw_dev_get_dsp_status function
* Please check the subsystem specification once more.
* How do you think about to replace the word “function” (in the summary phrase)
by parentheses?
> Added proper error handling for register value check that
Add?
> return -EPERM when register value does not meet expected condition
* It is usually preferred to end a sentence with a dot, isn't it?
* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
Regards,
Markus
Powered by blists - more mailing lists