linux-kernel - Re: [PATCH v2 1/2] rtc: m48t59: Use platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <95dac6fa-a93c-f5ce-355f-eb1ce7640cdb@linux-m68k.org>
Date: Tue, 8 Oct 2024 18:15:25 +1100 (AEDT)
From: Finn Thain <fthain@...ux-m68k.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
cc: "David S. Miller" <davem@...emloft.net>, 
    Andreas Larsson <andreas@...sler.com>, 
    Alexandre Belloni <alexandre.belloni@...tlin.com>, 
    Daniel Palmer <daniel@...f.com>, Michael Pavone <pavone@...rodev.com>, 
    linux-m68k@...ts.linux-m68k.org, linux-rtc@...r.kernel.org, 
    sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] rtc: m48t59: Use platform_data struct for year
 offset value


On Tue, 8 Oct 2024, Geert Uytterhoeven wrote:

> Hi Finn,
> 
> On Tue, Oct 8, 2024 at 12:43 AM Finn Thain <fthain@...ux-m68k.org> wrote:
> > Instead of hard-coded values and ifdefs, store the year offset in the
> > platform_data struct.
> >
> > Tested-by: Daniel Palmer <daniel@...f.com>
> > Signed-off-by: Finn Thain <fthain@...ux-m68k.org>
> 
> Thanks for your patch!
> 

Thanks for your review.

> > --- a/include/linux/rtc/m48t59.h
> > +++ b/include/linux/rtc/m48t59.h
> > @@ -56,6 +56,9 @@ struct m48t59_plat_data {
> >         void __iomem *ioaddr;
> >         /* offset to RTC registers, automatically set according to the type */
> >         unsigned int offset;
> > +
> > +       /* YY digits (in RTC) are offset, i.e. year is 1900 + yy_offset + YY */
> > +       time64_t yy_offset;
> 
> time64_t sounds like overkill to me...
> 

A vestige of an earlier experiment. Sorry about that. I shall send v3.