linux-kernel - Re: [PATCH v1 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMcHhXpSDe_kMc0hbOEzKu5fOqKTb_u-_H2CjFHdyi7TpTNQ=Q@mail.gmail.com>
Date: Tue, 8 Oct 2024 09:17:11 +0200
From: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
To: Doug Anderson <dianders@...omium.org>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Neil Armstrong <neil.armstrong@...aro.org>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Bryan.Kemp@...l.com, tudor.laurentiu.oss@...il.com, 
	Peter de Kraker <peterdekraker@...to.nl>
Subject: Re: [PATCH v1 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

On Tue, 8 Oct 2024 at 01:04, Doug Anderson <dianders@...omium.org> wrote:
>
> Hi,
>
> On Mon, Oct 7, 2024 at 1:14 PM Aleksandrs Vinarskis
> <alex.vinarskis@...il.com> wrote:
> >
> > Introduce low-res IPS and OLED panels for mentioned device.
> >
> > SHP panel's timings were picked experimentally, without this patch or with
> > `delay_200_500_e50` panel sometimes fails to boot/stays black on startup.
> >
> > LGD panel's timings were copied from other LGD panels and tested to be
> > working.
> >
> > Particular laptop also comes in high-res IPS variant, which unfortunately
> > I do not have access to verify.
> >
> > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
> > Tested-by: Peter de Kraker <peterdekraker@...to.nl>
>
> Your signed-off-by should be _below_ Peter's Tested-by. That means
> that you're the one that signed-off on the fact that Peter tested
> this.
>

Got it. I thought the author's signoff (me) would always be first.

> > ---
> >  drivers/gpu/drm/panel/panel-edp.c | 2 ++
> >  1 file changed, 2 insertions(+)
>
> This looks OK to me. I've been requesting people include the RAW EDID
> of panels that they add in the commit message, though. Could you do
> that and send a v2?

Probably missed that requirement, my bad, will respin.

> Also: note that since I didn't see Peter provide
> his Tested-by himself, I'd probably wait a little longer before
> landing to give him a chance to object.

I'll drop his test-by, and he can mail in himself directly then.

Thanks for the review
Alex
>
> -Doug