linux-kernel - Re: [PATCH 1/2] dt-bindings: pinctrl: amlogic,meson8-pinctrl-aobus: add reg for aobus pinctrl nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de6fda94-c8f3-473f-a3e7-f6d7f4192cdc@linaro.org>
Date: Tue, 8 Oct 2024 09:32:05 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, Jerome Brunet
 <jbrunet@...libre.com>, linux-amlogic@...ts.infradead.org,
 Conor Dooley <conor+dt@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Heiner Kallweit <hkallweit1@...il.com>, Kevin Hilman <khilman@...libre.com>,
 linux-gpio@...r.kernel.org,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: amlogic,meson8-pinctrl-aobus:
 add reg for aobus pinctrl nodes

On 07/10/2024 18:02, Rob Herring (Arm) wrote:
> 
> On Mon, 07 Oct 2024 16:16:25 +0200, Neil Armstrong wrote:
>> While converting the Amlogic Meson pinctrl binding to dt-schema, the mandatory
>> reg property for Meson8/b aobus pinctrl node was ommited, fix this to finally
>> pass all bindings checks.
>>
>> Fixes: 94df03a45276 ("dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding")
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>> ---
>>   .../pinctrl/amlogic,meson8-pinctrl-aobus.yaml      | 22 +++++++++++++++++++---
>>   1 file changed, 19 insertions(+), 3 deletions(-)
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/amlogic,meson8-pinctrl-aobus.example.dtb: pinctrl: 'reg' is a required property
> 	from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-aobus.yaml#
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241007-topic-amlogic-arm32-upstream-bindings-fixes-meson8-pinctrl-v1-1-d3d838540033@linaro.org
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 

Right, I thought I tested those bindings, but seems I missed something...

Thanks,
Neil