[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f5b027b7-7490-3f96-66a7-ff6513ba8309@mediatek.com>
Date: Tue, 8 Oct 2024 09:21:49 +0800
From: Macpaul Lin <macpaul.lin@...iatek.com>
To: Fei Shao <fshao@...omium.org>, AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
CC: Matthias Brugger <matthias.bgg@...il.com>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>,
Alexandre Mergnat <amergnat@...libre.com>, Bear Wang
<bear.wang@...iatek.com>, Pablo Sun <pablo.sun@...iatek.com>, Macpaul Lin
<macpaul@...il.com>, Sen Chu <sen.chu@...iatek.com>, Chris-qj chen
<chris-qj.chen@...iatek.com>, MediaTek Chromebook Upstream
<Project_Global_Chrome_Upstream_Group@...iatek.com>, Chen-Yu Tsai
<wenst@...omium.org>
Subject: Re: [PATCH] soc: mediatek: pwrap: add pwrap driver for MT8188 SoC
On 10/7/24 23:23, Fei Shao wrote:
>
>
> External email : Please do not click links or open attachments until you
> have verified the sender or the content.
>
> On Mon, Oct 7, 2024 at 10:55 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@...labora.com> wrote:
>>
>> Il 07/10/24 04:43, Macpaul Lin ha scritto:
>> > MT8188 are highly integrated SoC and use PMIC_MT6359 for
>> > power management. This patch adds pwrap master driver to
>> > access PMIC_MT6359.
>> >
>> > Signed-off-by: Sen Chu <sen.chu@...iatek.com>
>> > Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
>>
>> Actually, MT8188 and MT8195's pwrap registers and code flow are exactly the same:
>> since they are, we don't need this commit (or we don't need it right now!), and
>> we can just update the binding so that we can declare...
>>
>> compatible = "mediatek,mt8188-pwrap", "mediatek,mt8195-pwrap", "syscon";
>>
>> ...hence this driver doesn't get any commit :-)
>
> ... which is already the case. :)
> See commit 040c3303f110 ("dt-bindings: soc: mediatek: pwrap: Modify
> compatible for MT8188").
> And the device tree is set as well, so it's all good for MT8188 I believe.
>
> Cheers,
> Fei
>
Oh. Thank you for the reminder and point out the related commits.
Then this patch could be dropped.
Thanks!
Macpaul Lin
Powered by blists - more mailing lists