linux-kernel - Re: [PATCH] drivers/applicom:Removed the unused variable byte_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <af62c108-0f76-4df2-a56d-0b08d26853e9@app.fastmail.com>
Date: Tue, 08 Oct 2024 07:41:26 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: "Zhu Jun" <zhujun2@...s.chinamobile.com>
Cc: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/applicom:Removed the unused variable byte_reset_it

On Tue, Oct 8, 2024, at 07:28, Zhu Jun wrote:
> Remove unused variable and redundant readb in ac_register_board
>
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>

This is probably intentional, as the readb() can both have side-effects
on the device and serialize the device against a previous instructions.

It would have been nice to have a comment in there, but since that
is 30 year old code, I doubt we get more information on it now.

Just don't remove those.

      Arnd