linux-kernel - Re: [PATCH v8 14/14] sound: Make CONFIG_SND depend on INDIRECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87iku3vwjx.wl-tiwai@suse.de>
Date: Tue, 08 Oct 2024 10:16:50 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Julian Vetter <jvetter@...rayinc.com>
Cc: Arnd Bergmann <arnd@...db.de>,
	Russell King <linux@...linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Guo Ren <guoren@...nel.org>,
	Huacai Chen <chenhuacai@...nel.org>,
	WANG
 Xuerui <kernel@...0n.name>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Geert
 Uytterhoeven <geert@...ux-m68k.org>,
	Richard Henderson
 <richard.henderson@...aro.org>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Matt Turner <mattst88@...il.com>,
	"James E . J . Bottomley"
 <James.Bottomley@...senpartnership.com>,
	Helge Deller <deller@....de>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Rich Felker <dalias@...c.org>,
	John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
	Richard Weinberger
 <richard@....at>,
	Anton Ivanov <anton.ivanov@...bridgegreys.com>,
	Johannes
 Berg <johannes@...solutions.net>,
	Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>,
	Christophe Leroy
 <christophe.leroy@...roup.eu>,
	Naveen N Rao <naveen@...nel.org>,
	Madhavan
 Srinivasan <maddy@...ux.ibm.com>,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily
 Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle
 <svens@...ux.ibm.com>,
	Niklas Schnelle <schnelle@...ux.ibm.com>,
	Manivannan
 Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Miquel Raynal
 <miquel.raynal@...tlin.com>,
	Vignesh Raghavendra <vigneshr@...com>,
	Jaroslav
 Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-csky@...r.kernel.org,
	loongarch@...ts.linux.dev,
	linux-m68k@...ts.linux-m68k.org,
	linux-alpha@...r.kernel.org,
	linux-parisc@...r.kernel.org,
	linux-sh@...r.kernel.org,
	linux-um@...ts.infradead.org,
	linux-arch@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org,
	linux-s390@...r.kernel.org,
	mhi@...ts.linux.dev,
	linux-arm-msm@...r.kernel.org,
	linux-mtd@...ts.infradead.org,
	linux-sound@...r.kernel.org,
	Yann Sionneau
 <ysionneau@...rayinc.com>
Subject: Re: [PATCH v8 14/14] sound: Make CONFIG_SND depend on INDIRECT_IOMEM instead of UML

On Tue, 08 Oct 2024 09:50:22 +0200,
Julian Vetter wrote:
> 
> When building for the UM arch and neither INDIRECT_IOMEM=y, nor
> HAS_IOMEM=y is selected, the build fails because the memcpy_fromio and
> memcpy_toio functions are not defined. Fix it here by depending on
> HAS_IOMEM or INDIRECT_IOMEM.
> 
> Reviewed-by: Yann Sionneau <ysionneau@...rayinc.com>
> Signed-off-by: Julian Vetter <jvetter@...rayinc.com>
> ---
> Changes for v8:
> - New patch
> ---
>  sound/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/Kconfig b/sound/Kconfig
> index 4c036a9a420a..8b40205394fe 100644
> --- a/sound/Kconfig
> +++ b/sound/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  menuconfig SOUND
>  	tristate "Sound card support"
> -	depends on HAS_IOMEM || UML
> +	depends on HAS_IOMEM || INDIRECT_IOMEM
>  	help
>  	  If you have a sound card in your computer, i.e. if it can say more
>  	  than an occasional beep, say Y.

Acked-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi