[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZwTt0R_n40ohJqH1@shell.armlinux.org.uk>
Date: Tue, 8 Oct 2024 09:31:13 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Wei Fang <wei.fang@....com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, andrew@...n.ch, f.fainelli@...il.com,
hkallweit1@...il.com, andrei.botila@....nxp.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH v2 net-next 2/2] net: phy: c45-tja11xx: add support for
outputing RMII reference clock
On Tue, Oct 08, 2024 at 03:07:08PM +0800, Wei Fang wrote:
> @@ -1561,8 +1565,13 @@ static int nxp_c45_set_phy_mode(struct phy_device *phydev)
> phydev_err(phydev, "rmii mode not supported\n");
> return -EINVAL;
> }
> - phy_write_mmd(phydev, MDIO_MMD_VEND1, VEND1_MII_BASIC_CONFIG,
> - MII_BASIC_CONFIG_RMII);
> +
> + if (priv->flags & TJA11XX_REVERSE_MODE)
> + phy_write_mmd(phydev, MDIO_MMD_VEND1, VEND1_MII_BASIC_CONFIG,
> + MII_BASIC_CONFIG_RMII | MII_BASIC_CONFIG_REV);
> + else
> + phy_write_mmd(phydev, MDIO_MMD_VEND1, VEND1_MII_BASIC_CONFIG,
> + MII_BASIC_CONFIG_RMII);
Netdev has an 80 column limit, and this needs commenting because we have
PHY_INTERFACE_MODE_REVRMII which could be confused with this (although
I haven't checked.)
u16 basic_config;
...
basic_config = MII_BASIC_CONFIG_RMII;
/* This is not PHY_INTERFACE_MODE_REVRMII */
if (priv->flags & TJA11XX_REVERSE_MODE)
basic_config |= MII_BASIC_CONFIG_REV;
phy_write_mmd(phydev, MDIO_MMD_VEND1, VEND1_MII_BASIC_CONFIG,
basic_config);
is much nicer to read.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists