linux-kernel - Re: [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9277edf-d372-4a8e-881c-49a907f0a883@collabora.com>
Date: Tue, 8 Oct 2024 11:09:08 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Macpaul Lin <macpaul.lin@...iatek.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Seiya Wang <seiya.wang@...iatek.com>,
 Tinghan Shen <tinghan.shen@...iatek.com>,
 Chunfeng Yun <chunfeng.yun@...iatek.com>,
 Alexandre Mergnat <amergnat@...libre.com>
Cc: Bear Wang <bear.wang@...iatek.com>, Pablo Sun <pablo.sun@...iatek.com>,
 Macpaul Lin <macpaul@...il.com>, Sen Chu <sen.chu@...iatek.com>,
 Chris-qj chen <chris-qj.chen@...iatek.com>,
 MediaTek Chromebook Upstream
 <Project_Global_Chrome_Upstream_Group@...iatek.com>,
 Chen-Yu Tsai <wenst@...omium.org>
Subject: Re: [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for
 tphy

Il 08/10/24 09:15, Macpaul Lin ha scritto:
> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
> The error message was:
>    t-phy@...30000: 'power-domains' does not match any of the regexes:
>      '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> Fix this issue by dropping 'power-domains' of u3phy1 node.
> 
> This is because MediaTek tphy dose not need to add mtcmos.  It is not
> necessary to add 'power-domains'. If the power of the tphy is turned off,
> it will affect other functions. From the current USB hardware design
> perspective, even if mtcmos is added to the phy, it is always on.
> 
> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

> ---
>   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 -
>   1 file changed, 1 deletion(-)
> 
> Changes for v2:
>   - Add detail description of the tphy design for explaining the reason
>     of this change.
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index ade685ed2190..1c6f08dde31c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1920,7 +1920,6 @@ u3phy1: t-phy@...30000 {
>   			#address-cells = <1>;
>   			#size-cells = <1>;
>   			ranges = <0 0 0x11e30000 0xe00>;
> -			power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
>   			status = "disabled";
>   
>   			u2port1: usb-phy@0 {