linux-kernel - Re: [PATCH 2/2 V6] acpi/prmt: refactor acpi_platformrt_space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXEuPaqNh++1NPu3+ch0wmhsrtESJjPRWvvuUsyBUwB9=Q@mail.gmail.com>
Date: Tue, 8 Oct 2024 11:11:12 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: "Zhang, Rui" <rui.zhang@...el.com>
Cc: "mochs@...dia.com" <mochs@...dia.com>, "james.morse@....com" <james.morse@....com>, 
	"rafael@...nel.org" <rafael@...nel.org>, "lenb@...nel.org" <lenb@...nel.org>, 
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, "Ko, Koba" <kobak@...dia.com>, 
	"ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH 2/2 V6] acpi/prmt: refactor acpi_platformrt_space_handler
 to drop gotos

On Tue, 8 Oct 2024 at 05:24, Zhang, Rui <rui.zhang@...el.com> wrote:
>
> On Sun, 2024-10-06 at 23:36 +0800, KobaK wrote:
> > From: koba ko <kobak@...dia.com>
> >
> > Replace gotos with returns
> >
> > Signed-off-by: koba ko <kobak@...dia.com>
>
> I think my previous comment was valid because a different prm_status is
> returned, say, PRM_HANDLER_ERROR.
>
> Given that we return AE_OK directly for PRM_HANDLER_ERROR case in patch
> 1/2, I think it is okay to drop this patch.
>


Agreed