linux-kernel - Re: [PATCH net-next v3 1/1] Documentation: networking: add Twisted Pair Ethernet diagnostics at OSI Layer 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <460778bb-aa3c-4b5b-9bbc-a65833b9035c@redhat.com>
Date: Tue, 8 Oct 2024 11:44:11 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Florian Fainelli <f.fainelli@...il.com>,
 Maxime Chevallier <maxime.chevallier@...tlin.com>,
 Kory Maincent <kory.maincent@...tlin.com>, Lukasz Majewski <lukma@...x.de>,
 Jonathan Corbet <corbet@....net>
Cc: kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, Russell King <linux@...linux.org.uk>,
 Divya.Koppera@...rochip.com
Subject: Re: [PATCH net-next v3 1/1] Documentation: networking: add Twisted
 Pair Ethernet diagnostics at OSI Layer 1

Hi,

On 10/4/24 14:18, Oleksij Rempel wrote:
> This patch introduces a diagnostic guide for troubleshooting Twisted
> Pair  Ethernet variants at OSI Layer 1. It provides detailed steps for
> detecting  and resolving common link issues, such as incorrect wiring,
> cable damage,  and power delivery problems. The guide also includes
> interface verification  steps and PHY-specific diagnostics.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Very nice documentation! Just a minor not blocking note below.

[...]
> +- **Next Steps**:
> +
> +  - Record the output provided by `ethtool`, particularly noting the
> +    **master-slave status**, **speed**, **duplex**, and other relevant fields.
> +    This information will be useful for further analysis or troubleshooting.
> +    Once the **ethtool** output has been collected and stored, move on to the
> +    next diagnostic step.

Likely we will have to reword the this specific ethtool output at same 
point, and we will need to update this guide accordingly.

Cheers,

Paolo