linux-kernel - Re: [PATCH 1/1] riscv: sophgo: dts: add power key for pioneer box

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <klah6aevo4tr2lgrtsn6e3yoay6qjr2hpfmepjz22alsthd3no@p5r5tj3k6xx4>
Date: Tue, 8 Oct 2024 17:46:30 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, 
	Inochi Amaoto <inochiama@...il.com>, Chen Wang <unicornxw@...il.com>, aou@...s.berkeley.edu, 
	unicorn_wang@...look.com, conor+dt@...nel.org, guoren@...nel.org, inochiama@...look.com, 
	krzk+dt@...nel.org, palmer@...belt.com, paul.walmsley@...ive.com, robh@...nel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	chao.wei@...hgo.com, haijiao.liu@...hgo.com, xiaoguang.xing@...hgo.com, 
	chunzhi.lin@...hgo.com
Subject: Re: [PATCH 1/1] riscv: sophgo: dts: add power key for pioneer box

On Tue, Oct 08, 2024 at 11:28:24AM +0200, Krzysztof Kozlowski wrote:
> On 08/10/2024 07:18, Inochi Amaoto wrote:
> > On Tue, Oct 08, 2024 at 09:43:52AM +0800, Chen Wang wrote:
> >> From: Chen Wang <unicorn_wang@...look.com>
> >>
> >> There is a power button on the front panel of the pioneer box.
> >> Short pressing the button will trigger the onboard MCU to
> >> notify SG2042 through GPIO22 to enter the power-off process.
> >>
> >> Signed-off-by: Chen Wang <unicorn_wang@...look.com>
> >> ---
> >>  .../boot/dts/sophgo/sg2042-milkv-pioneer.dts      | 15 +++++++++++++++
> >>  1 file changed, 15 insertions(+)
> >>
> >> diff --git a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> >> index a3f9d6f22566..be596d01ff8d 100644
> >> --- a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> >> +++ b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> >> @@ -5,6 +5,9 @@
> >>  
> >>  #include "sg2042.dtsi"
> >>  
> >> +#include <dt-bindings/gpio/gpio.h>
> > 
> > Just move this include into sg204.dtsi. It seems you forgot to
> 
> sg204.dtsi does not use this header, so why it should be there?
> 
> DTS does not differ here from C. You include only what is being directly
> used.
> 

OK, it is my misunderstanding, I thought this header is binded 
to the GPIO device. Let's drop my advice.

Regard,
Inochi