linux-kernel - Re: [PATCH] drivers/rtc:Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241008095443c9f8f39e@mail.local>
Date: Tue, 8 Oct 2024 11:54:43 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Zhu Jun <zhujun2@...s.chinamobile.com>
Cc: linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/rtc:Fix the wrong format specifier

Hello,

Please fix the subject line, it has to be in the subsystem style.

On 08/10/2024 02:25:17-0700, Zhu Jun wrote:
> The format specifier of "int" in sprintf() should be "%d", not
> "%u".
> 
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
> ---
>  drivers/rtc/rtc-rv3028.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c
> index 2f001c59c61d..c79fad316119 100644
> --- a/drivers/rtc/rtc-rv3028.c
> +++ b/drivers/rtc/rtc-rv3028.c
> @@ -162,7 +162,7 @@ static ssize_t timestamp0_count_show(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	return sprintf(buf, "%u\n", count);
> +	return sprintf(buf, "%d\n", count);
>  };
>  
>  static DEVICE_ATTR_RO(timestamp0_count);
> -- 
> 2.17.1
> 
> 
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com