linux-kernel - Re: [PATCH] spi: atmel-quadspi: Print the controller version and used irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwUJiAj_ZVztLvS5@finisterre.sirena.org.uk>
Date: Tue, 8 Oct 2024 11:29:28 +0100
From: Mark Brown <broonie@...nel.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Mihai Sain <mihai.sain@...rochip.com>, nicolas.ferre@...rochip.com,
	alexandre.belloni@...tlin.com, claudiu.beznea@...on.dev,
	linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: atmel-quadspi: Print the controller version and
 used irq

On Tue, Oct 08, 2024 at 10:34:39AM +0100, Tudor Ambarus wrote:
> On 10/8/24 9:32 AM, Mihai Sain wrote:

> > Add support to print the controller version and used irq
> > similar to other at91 drivers (spi, twi, usart).

> > +	dev_info(&pdev->dev, "AT91 QSPI Controller version %#x (irq %d)\n",
> > +		 atmel_qspi_read(aq, QSPI_VERSION), irq);

> This pollutes the console. Better to add a dev_dbg if you care.
> And irq number doesn't bring too much value as you can see it in dt,
> isn't it?

The objective of bringing the various AT91 drivers into consistency does
seem useful so if this isn't OK for this driver we should probably
update the other drivers as well.  Ensuring that people can get at the
IP version does feel useful, I guess it could also be a sysfs thing?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)