linux-kernel - Re: [PATCH v2 2/3] arm64: dts: rockchip: fix compatible string rk3328 cru node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e2ba7ae-b1e6-40ea-b2d3-7d8950cb367c@kernel.org>
Date: Tue, 8 Oct 2024 13:32:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Heiko Stuebner <heiko@...ech.de>
Cc: mturquette@...libre.com, sboyd@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, jbx6244@...il.com,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: rockchip: fix compatible string rk3328
 cru node

On 30/09/2024 23:50, Heiko Stuebner wrote:
> From: Johan Jonker <jbx6244@...il.com>
> 
> The cru node references undocumented compatibles of "rockchip,cru" and also
> marks it as syscon.
> 
> A general rockchip,cru is way too generic to ever be used anywhere, so
> needs to go away, similarly the cru should not be written to from other
> places, instead regular clock routines should be used.
> 
> Both mainline Linux as well as the vendor-kernel up to their 6.1 branch
> only reference the cru via the normal assigned-clocks, clocks and resets
> properties and do not get a syscon from the node.
> 
> Similarly, there is no syscon access by compatible both in mainline
> nor the vendor-kernel up to their 6.1 branch, through either the
> rockchip,rk3328-cru nor rockchip,cru compatibles.
> 
> So these two really are unused in all publically visible places.
> 
> Sidenote: the vendor-kernel does pretty crazy stuff in the camera interface
> and tdm driver, where they map the cru separately and set clock muxes and
> gates directly. This should of course never reach mainline anyway.
> 
> Signed-off-by: Johan Jonker <jbx6244@...il.com>
> [update commit message, to explain the unused compatibles]
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof