linux-kernel - Re: [PATCH 1/2] fs/super.c: introduce get_tree_bdev_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwUkJEtwIpUA4qMz@infradead.org>
Date: Tue, 8 Oct 2024 05:23:00 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>
Cc: Christoph Hellwig <hch@...radead.org>,
	Christian Brauner <brauner@...nel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
	Allison Karlitskaya <allison.karlitskaya@...hat.com>,
	Chao Yu <chao@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org
Subject: Re: [PATCH 1/2] fs/super.c: introduce get_tree_bdev_by_dev()

On Tue, Oct 08, 2024 at 08:10:45PM +0800, Gao Xiang wrote:
> But the error message out of get_tree_bdev() is inflexible and
> IMHO it's too coupled to `fc->source`.
> 
> > Otherwise just passing a quiet flag of some form feels like a much
> > saner interface.
> 
> I'm fine with this way, but that will be a treewide change, I
> will send out a version with a flag later.

I'd probably just add a get_tree_bdev_flags and pass 0 flags from
get_tree_bdev.