linux-kernel - Re: [PATCH AUTOSEL 6.11 72/76] drm/amdgpu: nuke the VM PD/PT shadow handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwUt5zNpjTMzweM9@sashalap>
Date: Tue, 8 Oct 2024 09:04:39 -0400
From: Sasha Levin <sashal@...nel.org>
To: Christian König <christian.koenig@....com>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Lijo Lazar <lijo.lazar@....com>,
	Alex Deucher <alexander.deucher@....com>, Xinhui.Pan@....com,
	airlied@...il.com, daniel@...ll.ch, sumit.semwal@...aro.org,
	mario.limonciello@....com, Hawking.Zhang@....com, le.ma@....com,
	hamza.mahfooz@....com, andrealmeid@...lia.com,
	victorchengchi.lu@....com, sunil.khatri@....com,
	chenxb_99091@....com, victor.skvortsov@....com, Jun.Ma2@....com,
	Yunxiang.Li@....com, Felix.Kuehling@....com,
	Arunpravin.PaneerSelvam@....com, tvrtko.ursulin@...lia.com,
	pierre-eric.pelloux-prayer@....com, Wang.Beyond@....com,
	shashank.sharma@....com, zhenguo.yin@....com, jesse.zhang@....com,
	Philip.Yang@....com, rajneesh.bhardwaj@....com, Tim.Huang@....com,
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-media@...r.kernel.org, linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH AUTOSEL 6.11 72/76] drm/amdgpu: nuke the VM PD/PT shadow
 handling

On Tue, Oct 08, 2024 at 08:46:01AM +0200, Christian König wrote:
>Hi Sasha,
>
>Am 04.10.24 um 20:17 schrieb Sasha Levin:
>>From: Christian König <christian.koenig@....com>
>>
>>[ Upstream commit 7181faaa4703705939580abffaf9cb5d6b50dbb7 ]
>>
>>This was only used as workaround for recovering the page tables after
>>VRAM was lost and is no longer necessary after the function
>>amdgpu_vm_bo_reset_state_machine() started to do the same.
>>
>>Compute never used shadows either, so the only proplematic case left is
>>SVM and that is most likely not recoverable in any way when VRAM is
>>lost.
>
>why is that backported to older kernels? It's basically just removing 
>an old and now unused feature.
>
>Lijo pointed out a related bug fixed by removing the feature, but that 
>only happens extremely rarely and in my view doesn't really justify a 
>backport.

I'll drop it then, thanks!

-- 
Thanks,
Sasha