linux-kernel - Re: [PATCH v3 1/1] phy: starfive: jh7110-usb: Fix link configuration to controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <SHXPR01MB0863C2FA75EA8D7621B5AAACE67E2@SHXPR01MB0863.CHNPR01.prod.partner.outlook.cn>
Date: Tue, 8 Oct 2024 02:13:24 +0000
From: Minda Chen <minda.chen@...rfivetech.com>
To: Conor Dooley <conor.dooley@...rochip.com>, Vinod Koul <vkoul@...nel.org>
CC: Kishon Vijay Abraham I <kishon@...nel.org>, Jan Kiszka
	<jan.kiszka@...mens.com>, "linux-phy@...ts.infradead.org"
	<linux-phy@...ts.infradead.org>, Emil Renner Berthing
	<emil.renner.berthing@...onical.com>, Rob Herring <robh+dt@...nel.org>, Conor
 Dooley <conor@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/1] phy: starfive: jh7110-usb: Fix link configuration
 to controller



> 
> On Mon, Sep 02, 2024 at 07:11:27PM +0800, Minda Chen wrote:
> > From: Jan Kiszka <jan.kiszka@...mens.com>
> >
> > In order to connect the USB 2.0 PHY to its controller, we also need to
> > set "u0_pdrstn_split_sw_usbpipe_plugen" [1]. Some downstream U-Boot
> > versions did that, but upstream firmware does not, and the kernel must
> > not rely on such behavior anyway. Failing to set this left the USB
> > gadget port invisible to connected hosts behind.
> >
> > Link:
> > https://doc-en.rvspace.org/JH7110/TRM/JH7110_TRM/sys_syscon.html#sys_s
> > yscon__section_b3l_fqs_wsb [1]
> > Fixes: 16d3a71c20cf ("phy: starfive: Add JH7110 USB 2.0 PHY driver")
> > Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> > Signed-off-by: Minda Chen <minda.chen@...rfivetech.com>
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Hi Vinod
   Could you review the new change of this patch? Thanks.