linux-kernel - Re: [PATCH v4 0/4] sched: Miscellaneous isolation related cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea3ebd17-981f-4269-aa22-a4ca31be335c@redhat.com>
Date: Wed, 9 Oct 2024 09:35:48 -0400
From: Waiman Long <llong@...hat.com>
To: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Juri Lelli <juri.lelli@...hat.com>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
 Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>,
 Frederic Weisbecker <frederic@...nel.org>
Cc: linux-kernel@...r.kernel.org, Phil Auld <pauld@...hat.com>
Subject: Re: [PATCH v4 0/4] sched: Miscellaneous isolation related cleanups

On 9/21/24 3:07 PM, Waiman Long wrote:
>   v4:
>    - Make "isolcpus=nohz" equivalent to "nohz_full" as suggested by
>      Federic.
>    - Update the scheduler code to use HK_TYPE_KERNEL_NOISE.
>
>   v3:
>    - Fix incorrect housekeeping_nohz_full_setup() flags setting.
>
>   v2:
>    - Remove HK_TYPE_SCHED and related dead code
>    - Change consolidated name from HK_TYPE_NOHZ_FULL to
>      HK_TYPE_KERNEL_NOSISE as suggested by Frederic and update
>      isolation.c as well.
>
> This series contains a number of miscellaneous sched/isolation related
> cleanups. Other than reducing the number of cpumasks in the housekeeping
> structure, there should be no other functional change.
>
> [v1] https://lore.kernel.org/lkml/20240818234520.90186-1-longman@redhat.com/
> [v2] https://lore.kernel.org/lkml/20240904171441.1048072-1-longman@redhat.com/
> [v3] https://lore.kernel.org/lkml/20240904183650.1053708-1-longman@redhat.com/
>
> Waiman Long (4):
>    sched/core: Remove HK_TYPE_SCHED
>    sched/isolation: Make "isolcpus=nohz" equivalent to "nohz_full"
>    sched/isolation: Consolidate housekeeping cpumasks that are always
>      identical
>    sched: Unify HK_TYPE_{TIMER|TICK|MISC} to HK_TYPE_KERNEL_NOISE
>
>   .../admin-guide/kernel-parameters.txt         |  4 +++-
>   include/linux/sched/isolation.h               | 21 +++++++++++-------
>   kernel/sched/core.c                           | 12 +++++-----
>   kernel/sched/fair.c                           | 19 +++-------------
>   kernel/sched/isolation.c                      | 22 ++++++++-----------
>   5 files changed, 34 insertions(+), 44 deletions(-)
>
Peter, are you fine with the changes in this series? I got the acks from 
Frederic, but I haven't receive any comments after that.

Thanks,
Longman