linux-kernel - Re: [PATCH v3] rust: query the compiler for dylib path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mS8F98WRsuc82Co6zyw1eYSGSQmr0brGwSkq-Zy4qivA@mail.gmail.com>
Date: Wed, 9 Oct 2024 16:28:44 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: rust-for-linux@...r.kernel.org, Daniel Gomez <da.gomez@...sung.com>, 
	Fiona Behrens <me@...enk.dev>, Masahiro Yamada <masahiroy@...nel.org>, 
	Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Thomas Weißschuh <linux@...ssschuh.net>, 
	"Steven Rostedt (Google)" <rostedt@...dmis.org>, Allison Henderson <allison.henderson@...cle.com>, 
	Íñigo Huguet <ihuguet@...hat.com>, 
	Kris Van Hees <kris.van.hees@...cle.com>, Vegard Nossum <vegard.nossum@...cle.com>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, linux-kernel@...r.kernel.org, 
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH v3] rust: query the compiler for dylib path

On Wed, Oct 9, 2024 at 4:16 PM Tamir Duberstein <tamird@...il.com> wrote:
>
> Rust proc-macro crates are loaded by the compiler at compile-time, so
> are always dynamic libraries; on macOS, these artifacts get a .dylib
> extension rather than .so.
>
> Replace hardcoded paths ending in .so with paths obtained from the
> compiler.

Nit: this should mention what the overall purpose of the patch is,
i.e. "why we are doing this?", i.e. supporting macOS builds. It is
maybe obvious since macOS is mentioned (in the "what does this patch
do?" part), but it is best to be explicit.

> Co-developed-by: Fiona Behrens <me@...enk.dev>
> Signed-off-by: Tamir Duberstein <tamird@...il.com>

Please read the section of the documentation I linked, it contains an
example on how this should be done, i.e. the Co-developed-by tag
cannot be on its own:

    https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

`scripts/checkpatch.pl` also warns about this -- please run patches through it:

    WARNING: Co-developed-by and Signed-off-by: name/email do not match

Cheers,
Miguel