linux-kernel - Re: [PATCH 04/14] objtool/x86: Add .tail_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241009152503.GR17263@noisy.programming.kicks-ass.net>
Date: Wed, 9 Oct 2024 17:25:03 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, alyssa.milburn@...el.com,
	scott.d.constable@...el.com, joao@...rdrivepizza.com,
	andrew.cooper3@...rix.com, jose.marchesi@...cle.com,
	hjl.tools@...il.com, ndesaulniers@...gle.com,
	samitolvanen@...gle.com, nathan@...nel.org, ojeda@...nel.org,
	kees@...nel.org, alexei.starovoitov@...il.com
Subject: Re: [PATCH 04/14] objtool/x86: Add .tail_call_sites

On Fri, Sep 27, 2024 at 04:42:47PM -0700, Josh Poimboeuf wrote:
> On Fri, Sep 27, 2024 at 09:49:00PM +0200, Peter Zijlstra wrote:
> > @@ -893,7 +893,6 @@ static int create_cfi_sections(struct ob
> >  
> >  	sec = find_section_by_name(file->elf, ".cfi_sites");
> >  	if (sec) {
> > -		INIT_LIST_HEAD(&file->call_list);
> 
> Hm, why exactly are we re-initing the list head anyway in these
> boilerplate create_*_sections() functions?  I'm guessing that backfired
> here.  I can't figure out a reason why we'd doing that anyway.

Yeah, I can't remember where that came from, nor why I removed this
particular one :/

> I'm also wondering why we made these boilerplate function names plural
> "sections" when they only create a single section :-)

Because elf_create_section_pair() creates two section_s_, right?