linux-kernel - Re: [PATCH] rust: remove unnecessary #includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nUT6cFXCGg4jfN07W7UE-8vma=o9a5DQjsRwtNsKUGbQ@mail.gmail.com>
Date: Wed, 9 Oct 2024 17:58:31 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Dirk Behme <dirk.behme@...il.com>
Cc: Tamir Duberstein <tamird@...il.com>, rust-for-linux@...r.kernel.org, 
	Gary Guo <gary@...yguo.net>, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Dirk Behme <dirk.behme@...bosch.com>, Filipe Xavier <felipe_life@...e.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: remove unnecessary #includes

On Wed, Oct 9, 2024 at 5:37 PM Dirk Behme <dirk.behme@...il.com> wrote:
>
> * Theoretically the grammer fix in exports.c could go into an
> independent patch. But if not it at least should be mentioned in the
> commit message. Let Miguel decide if he wants an extra patch or not ;)

Indeed, in general, one should not have unstated/unrelated changes.

> * Maybe a
>
> Fixes: e26fa546042a ("rust: kbuild: auto generate helper exports")
>
> tag could be added? Even though Miguel might route it through
> rust-next as its not urgent for routing through rust-fixes.

I think this is a cleanup, i.e. just unnecessary `#include`s being
present, right? In other words, there is no "bug" apart from not being
optimal (one could see cleanups as things that should have been done,
but I guess we should draw the line somewhere).

Andreas: was there a reason to keep those `#include`s, just in case?

Thanks!

Cheers,
Miguel