linux-kernel - Re: [PATCH net-next 01/11] dt-bindings: net: add compatible string for i.MX95 EMDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zwauy1WYZtHmwmFC@lizhi-Precision-Tower-5810>
Date: Wed, 9 Oct 2024 12:26:51 -0400
From: Frank Li <Frank.li@....com>
To: Wei Fang <wei.fang@....com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, vladimir.oltean@....com,
	claudiu.manoil@....com, xiaoning.wang@....com,
	christophe.leroy@...roup.eu, linux@...linux.org.uk,
	bhelgaas@...gle.com, imx@...ts.linux.dev, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH net-next 01/11] dt-bindings: net: add compatible string
 for i.MX95 EMDIO

On Wed, Oct 09, 2024 at 05:51:06PM +0800, Wei Fang wrote:
> The EMDIO of i.MX95 has been upgraded to revision 4.1, and the vendor
> ID and device ID have also changed, so add the new compatible strings
> for i.MX95 EMDIO.
>
> Signed-off-by: Wei Fang <wei.fang@....com>
> ---
>  .../devicetree/bindings/net/fsl,enetc-mdio.yaml   | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> index c1dd6aa04321..71f1e32b00dc 100644
> --- a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> @@ -20,10 +20,17 @@ maintainers:
>
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - pci1957,ee01
> -      - const: fsl,enetc-mdio
> +    oneOf:
> +      - items:
> +          - enum:
> +              - pci1957,ee01
> +          - const: fsl,enetc-mdio
> +      - items:
> +          - const: pci1131,ee00
> +      - items:
> +          - enum:
> +              - nxp,netc-emdio
> +          - const: pci1131,ee00

why reverse order here. suggested:

oneOf:
  - items:
      - enum:
          - pci1957,ee01
          - pci1131,ee00
      - const: fsl,enetc-mdio
  - items:
      - const: pci1131,ee00

Frank
>
>    reg:
>      maxItems: 1
> --
> 2.34.1
>