linux-kernel - Re: [PATCH v2 14/15] media: anysee: Fix link to outdated sleep function documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwavtEHr_29NTvTg@localhost.localdomain>
Date: Wed, 9 Oct 2024 18:30:44 +0200
From: Frederic Weisbecker <frederic@...nel.org>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>
Cc: Thomas Gleixner <tglx@...utronix.de>, Jonathan Corbet <corbet@....net>,
	linux-kernel@...r.kernel.org, Len Brown <len.brown@...el.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org
Subject: Re: [PATCH v2 14/15] media: anysee: Fix link to outdated sleep
 function documentation

Le Wed, Sep 11, 2024 at 07:13:40AM +0200, Anna-Maria Behnsen a écrit :
> The TODO FIXME comment references the outdated lower limit for msleep()
> function of 20ms. As this is not right and the proper documentation of
> msleep() is now part of the function description, remove the old stuff and
> point to the up to date documentation.
> 
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: linux-media@...r.kernel.org
> Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>
> ---
>  drivers/media/usb/dvb-usb-v2/anysee.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
> index 8699846eb416..b2f5db961245 100644
> --- a/drivers/media/usb/dvb-usb-v2/anysee.c
> +++ b/drivers/media/usb/dvb-usb-v2/anysee.c
> @@ -55,10 +55,8 @@ static int anysee_ctrl_msg(struct dvb_usb_device *d,
>  
>  	/* TODO FIXME: dvb_usb_generic_rw() fails rarely with error code -32
>  	 * (EPIPE, Broken pipe). Function supports currently msleep() as a
> -	 * parameter but I would not like to use it, since according to
> -	 * Documentation/timers/timers-howto.rst it should not be used such
> -	 * short, under < 20ms, sleeps. Repeating failed message would be
> -	 * better choice as not to add unwanted delays...
> +	 * parameter. Check msleep() for details. Repeating failed message would
> +	 * be better choice as not to add unwanted delays...

Does the comment still matches any up-to-date worry? It passes 2000 ms which is
2 seconds...

Thanks.

>  	 * Fixing that correctly is one of those or both;
>  	 * 1) use repeat if possible
>  	 * 2) add suitable delay
> 
> -- 
> 2.39.2
>