linux-kernel - Re: [PATCH] arm64: dts: qcom: sm8450: Add Broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwawkF17sxYRk_vC@hovoldconsulting.com>
Date: Wed, 9 Oct 2024 18:34:24 +0200
From: Johan Hovold <johan@...nel.org>
To: Abel Vesa <abel.vesa@...aro.org>
Cc: Konrad Dybcio <konrad.dybcio@...aro.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Rajendra Nayak <quic_rjendra@...cinc.com>,
	Sibi Sankar <quic_sibis@...cinc.com>, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8450: Add Broadcast_AND region in
 LLCC block

On Thu, Jul 18, 2024 at 03:45:54PM +0300, Abel Vesa wrote:
> On 24-07-18 13:28:49, Johan Hovold wrote:
> > On Thu, Jul 18, 2024 at 01:20:37PM +0200, Konrad Dybcio wrote:
> > > On 18.07.2024 12:20 PM, Abel Vesa wrote:
> > > > Add missing Broadcast_AND region to the LLCC block for x1e80100,
> > > > as the LLCC version on this platform is 4.1 and it provides the region.
> > > > 
> > > > This also fixes the following error caused by the missing region:
> > > > 
> > > > [    3.797768] qcom-llcc 25000000.system-cache-controller: error -EINVAL: invalid resource (null)
> > 
> > Please say something about this error only showing up in linux-next,
> > which has 055afc34fd21 ("soc: qcom: llcc: Add regmap for Broadcast_AND region"
> > region")).
> 
> Hm, now that I think of it, maybe I should drop the fixes tag
> altogether, as it fits more into the "new support" category strictly
> because of that commit you mentioned.

Looks like you forgot to respin this one so that the error is now logged
with mainline since 6.11 and commit 055afc34fd21 ("soc: qcom: llcc: Add
regmap for Broadcast_AND region"):

	qcom-llcc 25000000.system-cache-controller: error -EINVAL: invalid resource (null)

Can you please respin as soon as possible with an updated commit message
and a CC stable tag to suppress the error?

> > > > Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts")
> > > > Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> > > > ---
> > > 
> > > Please fix the commit title
> > 
> > And that.
> 
> Yep. Will do.

Don't forget to update Subject.

Johan