linux-kernel - Re: [PATCH 1/1] lockdep: Enable PROVE_RAW_LOCK_NESTING with PROVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a323429f-66e8-4951-a674-54dc25429a15@redhat.com>
Date: Wed, 9 Oct 2024 12:50:39 -0400
From: Waiman Long <llong@...hat.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 linux-kernel@...r.kernel.org
Cc: Boqun Feng <boqun.feng@...il.com>, Ingo Molnar <mingo@...hat.com>,
 Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>,
 Will Deacon <will@...nel.org>
Subject: Re: [PATCH 1/1] lockdep: Enable PROVE_RAW_LOCK_NESTING with
 PROVE_LOCKING.


On 10/9/24 11:45 AM, Sebastian Andrzej Siewior wrote:
> With the printk issues solved, the last known splat created by
> PROVE_RAW_LOCK_NESTING is gone.
>
> Enable PROVE_RAW_LOCK_NESTING by default as part of PROVE_LOCKING. Keep
> the defines around in case something serious pops up and it needs to be
> disabled.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
>   lib/Kconfig.debug | 12 ++----------
>   1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 7315f643817ae..5b67816f4a62f 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1409,22 +1409,14 @@ config PROVE_LOCKING
>   	 For more details, see Documentation/locking/lockdep-design.rst.
>   
>   config PROVE_RAW_LOCK_NESTING
> -	bool "Enable raw_spinlock - spinlock nesting checks"
> +	bool
>   	depends on PROVE_LOCKING
> -	default n
> +	default y
>   	help
>   	 Enable the raw_spinlock vs. spinlock nesting checks which ensure
>   	 that the lock nesting rules for PREEMPT_RT enabled kernels are
>   	 not violated.
>   
> -	 NOTE: There are known nesting problems. So if you enable this
> -	 option expect lockdep splats until these problems have been fully
> -	 addressed which is work in progress. This config switch allows to
> -	 identify and analyze these problems. It will be removed and the
> -	 check permanently enabled once the main issues have been fixed.
> -
> -	 If unsure, select N.
> -
>   config LOCK_STAT
>   	bool "Lock usage statistics"
>   	depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
Acked-by: Waiman Long <longman@...hat.com>