linux-kernel - Re: [PATCH v2 2/2] erofs: use get_tree_bdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ec1896f-93da-4eca-ab69-8ae9d1645181@linux.alibaba.com>
Date: Thu, 10 Oct 2024 00:57:26 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Christian Brauner <brauner@...nel.org>,
 Christoph Hellwig <hch@...radead.org>, Jan Kara <jack@...e.cz>
Cc: Alexander Viro <viro@...iv.linux.org.uk>,
 Allison Karlitskaya <allison.karlitskaya@...hat.com>,
 Chao Yu <chao@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
 linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org
Subject: Re: [PATCH v2 2/2] erofs: use get_tree_bdev_flags() to avoid
 misleading messages



On 2024/10/9 15:37, Gao Xiang wrote:
> Hi Christoph,
> 

...

>>>
>>> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
>>> index 666873f745da..b89836a8760d 100644
>>> --- a/fs/erofs/super.c
>>> +++ b/fs/erofs/super.c
>>> @@ -705,7 +705,9 @@ static int erofs_fc_get_tree(struct fs_context *fc)
>>>       if (IS_ENABLED(CONFIG_EROFS_FS_ONDEMAND) && sbi->fsid)
>>>           return get_tree_nodev(fc, erofs_fc_fill_super);
>>> -    ret = get_tree_bdev(fc, erofs_fc_fill_super);
>>> +    ret = get_tree_bdev_flags(fc, erofs_fc_fill_super,
>>> +        IS_ENABLED(CONFIG_EROFS_FS_BACKED_BY_FILE) ?
>>> +            GET_TREE_BDEV_QUIET_LOOKUP : 0);
>>
>> Why not pass it unconditionally and provide your own more useful
>> error message at the end of the function if you could not find any
>> source?
> 
> My own (potential) concern is that if CONFIG_EROFS_FS_BACKED_BY_FILE
> is off, EROFS should just behave as other pure bdev fses since I'm
> not sure if some userspace program really relies on
> "Can't lookup blockdev" behavior.
> 
> .. Yet that is just my own potential worry anyway.

Many thanks all for the review... So I guess it sounds fine?



Hi Christian,

If they also look good to you, since it's a VFS change,
if possible, could you apply these two patches through
the VFS tree for this cycle?  There is a redundant blank
line removal in the first patch, I guess you could help
adjust or I need to submit another version?

I also have another related fix in erofs tree to address
a syzbot issue
https://lore.kernel.org/r/20240917130803.32418-1-hsiangkao@linux.alibaba.com

but it shouldn't cause any conflict with the second
patch though..

Thanks,
Gao Xiang

> 
> Thanks,
> Gao Xiang
>