Message-ID: <8643a212-884c-48de-a2d0-0f068fc49ca2@gmail.com>
Date: Wed, 9 Oct 2024 20:32:30 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: Philipp Stanner <pstanner@...hat.com>, Damien Le Moal
 <dlemoal@...nel.org>, Niklas Cassel <cassel@...nel.org>,
 Sergey Shtylyov <s.shtylyov@....ru>,
 Basavaraj Natikar <basavaraj.natikar@....com>, Jiri Kosina
 <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
 Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Alex Dubov
 <oakad@...oo.com>, Sudarsana Kalluru <skalluru@...vell.com>,
 Manish Chopra <manishc@...vell.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rasesh Mody <rmody@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
 Igor Mitsyanko <imitsyanko@...ntenna.com>,
 Sergey Matyukevich <geomatsi@...il.com>, Kalle Valo <kvalo@...nel.org>,
 Sanjay R Mehta <sanju.mehta@....com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>, Jon Mason <jdmason@...zu.us>,
 Dave Jiang <dave.jiang@...el.com>, Allen Hubbe <allenbh@...il.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Alex Williamson <alex.williamson@...hat.com>, Juergen Gross
 <jgross@...e.com>, Stefano Stabellini <sstabellini@...nel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Mario Limonciello <mario.limonciello@....com>, Chen Ni <nichen@...as.ac.cn>,
 Ricky Wu <ricky_wu@...ltek.com>, Al Viro <viro@...iv.linux.org.uk>,
 Breno Leitao <leitao@...ian.org>, Kevin Tian <kevin.tian@...el.com>,
 Thomas Gleixner <tglx@...utronix.de>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Mostafa Saleh <smostafa@...gle.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Hannes Reinecke <hare@...e.de>, John Garry <john.g.garry@...cle.com>,
 Soumya Negi <soumya.negi97@...il.com>, Jason Gunthorpe <jgg@...pe.ca>,
 Yi Liu <yi.l.liu@...el.com>, "Dr. David Alan Gilbert" <linux@...blig.org>,
 Christian Brauner <brauner@...nel.org>, Ankit Agrawal <ankita@...dia.com>,
 Reinette Chatre <reinette.chatre@...el.com>,
 Eric Auger <eric.auger@...hat.com>, Ye Bin <yebin10@...wei.com>,
 Marek Marczykowski-Górecki
 <marmarek@...isiblethingslab.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
 Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
 Rui Salvaterra <rsalvaterra@...il.com>, Marc Zyngier <maz@...nel.org>
Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-input@...r.kernel.org, netdev@...r.kernel.org,
 linux-wireless@...r.kernel.org, ntb@...ts.linux.dev,
 linux-pci@...r.kernel.org, linux-staging@...ts.linux.dev,
 kvm@...r.kernel.org, xen-devel@...ts.xenproject.org,
 linux-sound@...r.kernel.org
Subject: Re: [RFC PATCH 00/13] Remove implicit devres from pci_intx()

On 09.10.2024 10:35, Philipp Stanner wrote:
> Hi all,
> 
> this series removes a problematic feature from pci_intx(). That function
> sometimes implicitly uses devres for automatic cleanup. We should get
> rid of this implicit behavior.
> 
> To do so, a pci_intx() version that is always-managed, and one that is
> never-managed are provided. Then, all pci_intx() users are ported to the
> version they need. Afterwards, pci_intx() can be cleaned up and the
> users of the never-managed version be ported back to pci_intx().
> 
> This way we'd get this PCI API consistent again.
> 
AFAICS pci_intx() is used only by drivers which haven't been converted
to the pci_alloc_irq_vectors() API yet. Wouldn't it be better to do this
instead of trying to improve pci_intx()?
Eventually pci_intx() would have to be used in PCI core only.

> The last patch obviously reverts the previous patches that made drivers
> use pci_intx_unmanaged(). But this way it's easier to review and
> approve. It also makes sure that each checked out commit should provide
> correct behavior, not just the entire series as a whole.
> 
> Merge plan for this would be to enter through the PCI tree.
> 
> Please say so if you've got concerns with the general idea behind the
> RFC.
> 
> Regards,
> P.
> 
> Philipp Stanner (13):
>   PCI: Prepare removing devres from pci_intx()
>   ALSA: hda: hda_intel: Use always-managed version of pcim_intx()
>   drivers/xen: Use never-managed version of pci_intx()
>   net/ethernet: Use never-managed version of pci_intx()
>   net/ntb: Use never-managed version of pci_intx()
>   misc: Use never-managed version of pci_intx()
>   vfio/pci: Use never-managed version of pci_intx()
>   PCI: MSI: Use never-managed version of pci_intx()
>   ata: Use always-managed version of pci_intx()
>   staging: rts5280: Use always-managed version of pci_intx()
>   wifi: qtnfmac: use always-managed version of pcim_intx()
>   HID: amd_sfh: Use always-managed version of pcim_intx()
>   Remove devres from pci_intx()
> 
>  drivers/ata/ahci.c                            |  2 +-
>  drivers/ata/ata_piix.c                        |  2 +-
>  drivers/ata/pata_rdc.c                        |  2 +-
>  drivers/ata/sata_sil24.c                      |  2 +-
>  drivers/ata/sata_sis.c                        |  2 +-
>  drivers/ata/sata_uli.c                        |  2 +-
>  drivers/ata/sata_vsc.c                        |  2 +-
>  drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        |  4 ++--
>  drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c |  2 +-
>  .../wireless/quantenna/qtnfmac/pcie/pcie.c    |  2 +-
>  drivers/pci/devres.c                          | 24 +++----------------
>  drivers/pci/pci.c                             | 14 +----------
>  drivers/staging/rts5208/rtsx.c                |  2 +-
>  include/linux/pci.h                           |  1 +
>  sound/pci/hda/hda_intel.c                     |  2 +-
>  15 files changed, 18 insertions(+), 47 deletions(-)
> 

Powered by blists - more mailing lists