linux-kernel - Re: [PATCH v3 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172850335071.570182.9793183065235967586.robh@kernel.org>
Date: Wed, 09 Oct 2024 14:49:11 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Frank Wunderlich <linux@...web.de>
Cc: linux-arm-kernel@...ts.infradead.org, eladwf@...il.com, 
 daniel@...rotopia.org, ansuelsmth@...il.com, 
 Conor Dooley <conor+dt@...nel.org>, 
 Frank Wunderlich <frank-w@...lic-files.de>, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 linux-kernel@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>, 
 linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org, 
 Matthias Brugger <matthias.bgg@...il.com>, john@...ozen.org, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-mmc@...r.kernel.org, 
 Chaotian Jing <chaotian.jing@...iatek.com>, 
 Wenbin Mei <wenbin.mei@...iatek.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC


On Wed, 09 Oct 2024 18:55:41 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@...lic-files.de>
> 
> Add binding definitions for mmc on MT7988 SoC.
> 
> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> ---
> v3:
> - fixed minItems on clock-names too
> v2:
> - fixed minItems to 4
> ---
>  .../devicetree/bindings/mmc/mtk-sd.yaml       | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: allOf:5:then:properties:clocks: 'oneOf' conditional failed, one must be fixed:
	[{'description': 'source clock'}, {'description': 'HCLK which used for host'}, {'description': 'Advanced eXtensible Interface'}, {'description': 'Advanced High-performance Bus clock'}] is too long
	[{'description': 'source clock'}, {'description': 'HCLK which used for host'}, {'description': 'Advanced eXtensible Interface'}, {'description': 'Advanced High-performance Bus clock'}] is too short
	False schema does not allow 4
	1 was expected
	4 is greater than the maximum of 2
	4 is greater than the maximum of 3
	hint: "minItems" is only needed if less than the "items" list length
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: allOf:5:then:properties:clock-names: 'oneOf' conditional failed, one must be fixed:
	[{'const': 'source'}, {'const': 'hclk'}, {'const': 'axi_cg'}, {'const': 'ahb_cg'}] is too long
	[{'const': 'source'}, {'const': 'hclk'}, {'const': 'axi_cg'}, {'const': 'ahb_cg'}] is too short
	False schema does not allow 4
	1 was expected
	4 is greater than the maximum of 2
	4 is greater than the maximum of 3
	hint: "minItems" is only needed if less than the "items" list length
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241009165547.5959-2-linux@fw-web.de

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.