linux-kernel - Re: [PATCH] misc: sgi-gru: Don't disable preemption in GRU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whVb6ahr=-YpiVqvhCKj+GHME_J0cRi6tn21TPwV7B9SQ@mail.gmail.com>
Date: Wed, 9 Oct 2024 12:49:23 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Dimitri Sivanich <sivanich@....com>
Cc: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Dan Carpenter <dan.carpenter@...aro.org>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: sgi-gru: Don't disable preemption in GRU driver

On Thu, 19 Sept 2024 at 06:16, Dimitri Sivanich <sivanich@....com> wrote:
>
> Disabling preemption in the GRU driver is unnecessary, and clashes with
> sleeping locks in several code paths.  Remove preempt_disable and
> preempt_enable from the GRU driver.

I've applied this directly, since it didn't come in through any of the
normal channels, and I don't see it pending anywhere in linux-next
either.

I doubt it matters much in practice, but at least it should make
smatch happier about this driver, and clearly the preemption disabling
was always wrong.

              Linus