linux-kernel - Re: [PATCH] mm: Enforce a minimal stack gap even against inaccessible VMAs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20241009140822.0628a4d09312cbc19d73c6e4@linux-foundation.org>
Date: Wed, 9 Oct 2024 14:08:22 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: kernel test robot <lkp@...el.com>, Jann Horn <jannh@...gle.com>,
 oe-kbuild-all@...ts.linux.dev, Linux Memory Management List
 <linux-mm@...ck.org>, Hugh Dickins <hughd@...gle.com>, Oleg Nesterov
 <oleg@...hat.com>, Michal Hocko <mhocko@...e.com>, Helge Deller
 <deller@....de>, Vlastimil Babka <vbabka@...e.cz>, Ben Hutchings
 <bwh@...nel.org>, Willy Tarreau <w@....eu>, Rik van Riel <riel@...hat.com>,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] mm: Enforce a minimal stack gap even against
 inaccessible VMAs

On Wed, 9 Oct 2024 15:53:50 +0100 Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:

> > All errors (new ones prefixed by >>):
> >
> >    mm/mmap.c: In function 'expand_upwards':
> > >> mm/mmap.c:1069:39: error: 'prev' undeclared (first use in this function)
> >     1069 |                 if (vma_is_accessible(prev))
> 
> Suspect this is just a simple typo and should be next rather than prev :>)

Agree, I'll make that change.

CONFIG_STACK_GROWSUP is only a parisc thing.  That makes runtime
testing difficult.