linux-kernel - Re: [PATCH 1/1] selftests/rseq: Fix mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <16c3dfe5-3e99-4376-a88b-96c4247cde32@linuxfoundation.org>
Date: Wed, 9 Oct 2024 15:12:58 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
 Boqun Feng <boqun.feng@...il.com>, "Paul E. McKenney" <paulmck@...nel.org>,
 Carlos O'Donell <carlos@...hat.com>, Florian Weimer <fweimer@...hat.com>,
 linux-kselftest@...r.kernel.org, stable@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 1/1] selftests/rseq: Fix mm_cid test failure

On 10/8/24 19:28, Mathieu Desnoyers wrote:
> Adapt the rseq.c/rseq.h code to follow GNU C library changes introduced by:
> 
> glibc commit 2e456ccf0c34 ("Linux: Make __rseq_size useful for feature detection (bug 31965)")
> 
> Without this fix, rseq selftests for mm_cid fail:
> 
> ./run_param_test.sh
> Default parameters
> Running test spinlock
> Running compare-twice test spinlock
> Running mm_cid test spinlock
> Error: cpu id getter unavailable
> 
> [ This is based on the following branch:
>    https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
>    branch: fixes ]

Did you forget version prefix? It get confusing without
it. Pleas eremeber to add prefix and version information.

> 
> Fixes: 18c2355838e7 ("selftests/rseq: Implement rseq mm_cid field support")
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> CC: Boqun Feng <boqun.feng@...il.com>
> CC: "Paul E. McKenney" <paulmck@...nel.org>
> Cc: Shuah Khan <skhan@...uxfoundation.org>
> CC: Carlos O'Donell <carlos@...hat.com>
> CC: Florian Weimer <fweimer@...hat.com>
> CC: linux-kselftest@...r.kernel.org
> CC: stable@...r.kernel.org
> ---

Applied to linux-kselftest fixes for next rc.

Did you forget version prefix? It was a bit confuing
>   tools/testing/selftests/rseq/rseq.c | 110 +++++++++++++++++++---------
>   tools/testing/selftests/rseq/rseq.h |  10 +--
>   2 files changed, 77 insertions(+), 43 deletions(-)
> 

thanks,
-- Shuah