linux-kernel - Re: [PATCH v2] of: Fix unbalanced of node refcount and memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a328b39f3f61371badc8d08de3dcab8.sboyd@kernel.org>
Date: Wed, 09 Oct 2024 15:12:05 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>, davidgow@...gle.com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, robh@...nel.org, saravanak@...gle.com
Cc: ruanjinjie@...wei.com
Subject: Re: [PATCH v2] of: Fix unbalanced of node refcount and memory leaks

Quoting Jinjie Ruan (2024-10-08 18:49:50)
> diff --git a/drivers/of/overlay_test.c b/drivers/of/overlay_test.c
> index 19a292cdeee3..e95b1152612c 100644
> --- a/drivers/of/overlay_test.c
> +++ b/drivers/of/overlay_test.c
> @@ -73,12 +73,12 @@ static void of_overlay_apply_kunit_cleanup(struct kunit *test)
>  
>         np = of_find_node_by_name(NULL, kunit_node_name);
>         KUNIT_ASSERT_NOT_ERR_OR_NULL(test, np);
> -       of_node_put_kunit(test, np);

Thanks for the patch. This should be

	of_node_put_kunit(&fake, np);

so that the node is put before the overlay is removed.

With that done you can add my

Reviewed-by: Stephen Boyd <sboyd@...nel.org>