linux-kernel - Re: [PATCH V3 11/11] accel/amdxdna: Add firmware debug buffer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7cd0ba15-2c60-3b0f-a388-46e7b46a09d7@amd.com>
Date: Wed, 9 Oct 2024 16:51:19 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: Jeffrey Hugo <quic_jhugo@...cinc.com>, <ogabbay@...nel.org>,
	<dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <min.ma@....com>, <max.zhen@....com>,
	<sonal.santan@....com>, <king.tam@....com>
Subject: Re: [PATCH V3 11/11] accel/amdxdna: Add firmware debug buffer support


On 10/9/24 09:22, Lizhi Hou wrote:
>
> On 10/4/24 11:33, Jeffrey Hugo wrote:
>> On 9/11/2024 12:06 PM, Lizhi Hou wrote:
>>> User application may allocate a debug buffer and attach it to an NPU
>>> context through the driver. Then the NPU firmware prints its debug
>>> information to this buffer for debugging.
>>
>> I feel like I must be missing something. It looks like this patch 
>> accepts a buffer from the user, and stores it. However I don't see 
>> how the NPU firmware ever learns that this special buffer exists to 
>> then use it.
>
> The debug function is incomplete while I was creating the patch. Thus, 
> I put a line in TODO "Improve debug bo support".
>
> We made progress on this feature. Should I add the code to V4 patch? 
> Or I can add it within future patches.

Discussed this more internally. And we would postpone debug_bo feature. 
Thus, I will  drop this patch for now.


Thanks,

Lizhi

>
>
> Thanks,
>
> Lizhi
>