linux-kernel - Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878quw7rrs.fsf@mail.lhotse>
Date: Thu, 10 Oct 2024 10:58:31 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Thomas Gleixner <tglx@...utronix.de>, Vincenzo Frascino
 <vincenzo.frascino@....com>, linux-kernel@...r.kernel.org,
 linux-arch@...r.kernel.org, linux-mm@...ck.org
Cc: Vincenzo Frascino <vincenzo.frascino@....com>, Andy Lutomirski
 <luto@...nel.org>, "Jason A . Donenfeld" <Jason@...c4.com>, Christophe
 Leroy <christophe.leroy@...roup.eu>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>, Ingo Molnar <mingo@...hat.com>, Borislav
 Petkov <bp@...en8.de>, Dave
 Hansen <dave.hansen@...ux.intel.com>, "H . Peter
 Anvin" <hpa@...or.com>, Theodore Ts'o <tytso@....edu>, Arnd Bergmann
 <arnd@...db.de>, Andrew Morton <akpm@...ux-foundation.org>, Steven Rostedt
 <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h

Thomas Gleixner <tglx@...utronix.de> writes:
> On Wed, Oct 09 2024 at 11:53, Thomas Gleixner wrote:
>> On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote:
>
> Hit send too early.
>
>>> +#if defined(CONFIG_PHYS_ADDR_T_64BIT)
>>> +#define PAGE_MASK	(~((1 << CONFIG_PAGE_SHIFT) - 1))
>
> This really wants a comment. The magic reliance on integer sign
> expansion is any thing than obvious.

+1

Vincenzo feel free to take/modify the one from arch/powerpc/include/asm/page.h :)

cheers