[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP-5=fVNcMq7xjPHFE-f=LddSDz4G2cWxUGDjSuFtafVAtY6bg@mail.gmail.com>
Date: Tue, 8 Oct 2024 17:48:49 -0700
From: Ian Rogers <irogers@...gle.com>
To: linux@...blig.org
Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
namhyung@...nel.org, mark.rutland@....com, alexander.shishkin@...ux.intel.com,
jolsa@...nel.org, adrian.hunter@...el.com, kan.liang@...ux.intel.com,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Remove unused color_fwrite_lines
On Tue, Oct 8, 2024 at 5:39 PM <linux@...blig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> color_fwrite_lines() was added by 2009's commit
> 8fc0321f1ad0 ("perf_counter tools: Add color terminal output support")
>
> but has never been used.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
Reviewed-by: Ian Rogers <irogers@...gle.com>
Thanks,
Ian
> ---
> tools/perf/util/color.c | 28 ----------------------------
> tools/perf/util/color.h | 1 -
> 2 files changed, 29 deletions(-)
>
> diff --git a/tools/perf/util/color.c b/tools/perf/util/color.c
> index bffbdd216a6a..e51f0a676a22 100644
> --- a/tools/perf/util/color.c
> +++ b/tools/perf/util/color.c
> @@ -93,34 +93,6 @@ int color_fprintf(FILE *fp, const char *color, const char *fmt, ...)
> return r;
> }
>
> -/*
> - * This function splits the buffer by newlines and colors the lines individually.
> - *
> - * Returns 0 on success.
> - */
> -int color_fwrite_lines(FILE *fp, const char *color,
> - size_t count, const char *buf)
> -{
> - if (!*color)
> - return fwrite(buf, count, 1, fp) != 1;
> -
> - while (count) {
> - char *p = memchr(buf, '\n', count);
> -
> - if (p != buf && (fputs(color, fp) < 0 ||
> - fwrite(buf, p ? (size_t)(p - buf) : count, 1, fp) != 1 ||
> - fputs(PERF_COLOR_RESET, fp) < 0))
> - return -1;
> - if (!p)
> - return 0;
> - if (fputc('\n', fp) < 0)
> - return -1;
> - count -= p + 1 - buf;
> - buf = p + 1;
> - }
> - return 0;
> -}
> -
> const char *get_percent_color(double percent)
> {
> const char *color = PERF_COLOR_NORMAL;
> diff --git a/tools/perf/util/color.h b/tools/perf/util/color.h
> index 01f7bed21c9b..aecf56dae73f 100644
> --- a/tools/perf/util/color.h
> +++ b/tools/perf/util/color.h
> @@ -39,7 +39,6 @@ int color_vsnprintf(char *bf, size_t size, const char *color,
> int color_vfprintf(FILE *fp, const char *color, const char *fmt, va_list args);
> int color_fprintf(FILE *fp, const char *color, const char *fmt, ...);
> int color_snprintf(char *bf, size_t size, const char *color, const char *fmt, ...);
> -int color_fwrite_lines(FILE *fp, const char *color, size_t count, const char *buf);
> int value_color_snprintf(char *bf, size_t size, const char *fmt, double value);
> int percent_color_snprintf(char *bf, size_t size, const char *fmt, ...);
> int percent_color_len_snprintf(char *bf, size_t size, const char *fmt, ...);
> --
> 2.46.2
>
Powered by blists - more mailing lists