linux-kernel - Re: [PATCH v3 04/14] drm/mediatek: Fix XRGB setting error in Mixer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f1aef50c4a72f0d901191e18aa537e62cbc1fd1.camel@mediatek.com>
Date: Wed, 9 Oct 2024 06:27:59 +0000
From: Shawn Sung (宋孝謙) <Shawn.Sung@...iatek.com>
To: "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Bibby Hsieh (謝濟遠) <Bibby.Hsieh@...iatek.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>, "djkurtz@...omium.org"
	<djkurtz@...omium.org>, "Markus.Elfring@....de" <Markus.Elfring@....de>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	"daniel@...ll.ch" <daniel@...ll.ch>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "airlied@...il.com"
	<airlied@...il.com>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"littlecvr@...omium.org" <littlecvr@...omium.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: YT Shen (沈岳霆) <Yt.Shen@...iatek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 04/14] drm/mediatek: Fix XRGB setting error in Mixer

On Mon, 2024-10-07 at 13:36 +0200, Markus Elfring wrote:
> > Although the alpha channel in XRGB formats can be ignored,
> > ALPHA_CON
> > must be configured accordingly when using XRGB formats or it will
> > still
> > affects CRC generation.
> 
>   affect?

Yes, didn't notice that.
This is a typo, but the series has been merged.

> 
> 
> Can such a change description become a bit nicer with an additional
> imperative wording?
> 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94

Honestly, I wasn't familiar with the term "imerative mood" before this.
After studying it, I now understand. Thank you for pointing this out; I
will keep this in mind for the future.

As a result, I asked AI to refine the description using imperative
wording as a reference example:

"Ensure that ALPHA_CON is configured appropriately when using XRGB
formats, even though the alpha channel can be ignored. Failing to do so
will affect CRC generation."

Regards,
Shawn
> 
> Regards,
> Markus