[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241009074805.GC16181@lst.de>
Date: Wed, 9 Oct 2024 09:48:05 +0200
From: Christoph Hellwig <hch@....de>
To: Matias Bjørling <m@...rling.me>
Cc: kbusch@...nel.org, hch@....de, dlemoal@...nel.org, cassel@...nel.org,
linux-nvme@...ts.infradead.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org,
Matias Bjørling <matias.bjorling@....com>
Subject: Re: [PATCH 2/2] nvme: add rotational support
On Tue, Oct 08, 2024 at 04:55:03PM +0200, Matias Bjørling wrote:
> + if (info->is_rotational)
> + lim.features |= BLK_FEAT_ROTATIONAL | BLK_FEAT_ADD_RANDOM;
Entropy from block devices is pretty useless. The only reason we still
keep it for SCSI is because of retro-computing platforms without a proper
platform hardware RNG. NVMe HDDs reall should not show up in those kinds
of environments. Also without a add_disk_randomness in the nvme I/O
completion handler this won't actually do anything.
Powered by blists - more mailing lists