lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <442b62cc-a57d-04c4-0e25-07af7a0dad76@huawei.com>
Date: Wed, 9 Oct 2024 09:07:09 +0800
From: Zhihao Cheng <chengzhihao1@...wei.com>
To: SurajSonawane2415 <surajsonawane0215@...il.com>, <dwmw2@...radead.org>,
	<richard@....at>
CC: <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: jffs2: Fix inconsistent indentation in
 jffs2_mark_node_obsolete

在 2024/10/9 2:24, SurajSonawane2415 写道:
> From: Suraj Sonawane <surajsonawane0215@...il.com>
> 
> Fix the indentation to ensure consistent code style and improve
> readability, and to fix this warnings:
> fs/jffs2/nodemgmt.c:635 jffs2_mark_node_obsolete() warn: inconsistent
> indenting
> fs/jffs2/nodemgmt.c:646 jffs2_mark_node_obsolete() warn: inconsistent
> indenting
> 
> Signed-off-by: Suraj Sonawane <surajsonawane0215@...il.com>
> ---
>   fs/jffs2/nodemgmt.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 

Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>
> diff --git a/fs/jffs2/nodemgmt.c b/fs/jffs2/nodemgmt.c
> index bbab2bdc7..cc51c85ef 100644
> --- a/fs/jffs2/nodemgmt.c
> +++ b/fs/jffs2/nodemgmt.c
> @@ -630,8 +630,8 @@ void jffs2_mark_node_obsolete(struct jffs2_sb_info *c, struct jffs2_raw_node_ref
>   					  ref->flash_offset, jeb->used_size);
>   			BUG();
>   		})
> -			jffs2_dbg(1, "Obsoleting previously unchecked node at 0x%08x of len %x\n",
> -				  ref_offset(ref), freed_len);
> +		jffs2_dbg(1, "Obsoleting previously unchecked node at 0x%08x of len %x\n",
> +				ref_offset(ref), freed_len);
>   		jeb->unchecked_size -= freed_len;
>   		c->unchecked_size -= freed_len;
>   	} else {
> @@ -641,8 +641,8 @@ void jffs2_mark_node_obsolete(struct jffs2_sb_info *c, struct jffs2_raw_node_ref
>   					  ref->flash_offset, jeb->used_size);
>   			BUG();
>   		})
> -			jffs2_dbg(1, "Obsoleting node at 0x%08x of len %#x: ",
> -				  ref_offset(ref), freed_len);
> +		jffs2_dbg(1, "Obsoleting node at 0x%08x of len %#x: ",
> +				ref_offset(ref), freed_len);
>   		jeb->used_size -= freed_len;
>   		c->used_size -= freed_len;
>   	}
> 


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ