linux-kernel - Re: [PATCH v2?] ASoC: codecs: aw88399: Fix error handling in aw_dev_get_dsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01d7c030-1d80-4533-9279-2b6961e712ac@web.de>
Date: Wed, 9 Oct 2024 10:43:51 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Zhu Jun <zhujun2@...s.chinamobile.com>, linux-sound@...r.kernel.org,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Heiko Stübner <heiko@...ech.de>,
 Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Nathan Chancellor <nathan@...nel.org>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Weidong Wang <wangweidong.a@...nic.com>
Subject: Re: [PATCH v2?] ASoC: codecs: aw88399: Fix error handling in
 aw_dev_get_dsp_status function

How do you think about to replace the word “function” (in the summary phrase)
by parentheses?


> Added proper error handling for register value check that

  Add?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94


> return -EPERM when register value does not meet expected condition

* It is usually preferred to end such a sentence with a dot, isn't it?

* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?


…
> ---
>  sound/soc/codecs/aw88399.c | 2 +-

Please take version information better into account.

See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n321

* https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22


Regards,
Markus