linux-kernel - Re: [PATCH v4 1/3] dt-bindings: arm: qcom: Add Dell XPS 13 9345

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEvtbus6AK3-NHm98aO7O-PBYcaQ+VH_Mup5eViqMwCQrP1GFA@mail.gmail.com>
Date: Wed, 9 Oct 2024 10:54:15 +0200
From: Stefan Schmidt <stefan.schmidt@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Aleksandrs Vinarskis <alex.vinarskis@...il.com>, Bjorn Andersson <andersson@...nel.org>, 
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, robdclark@...il.com, 
	peterdekraker@...to.nl, Bryan.Kemp@...l.com, tudor.laurentiu.oss@...il.com
Subject: Re: [PATCH v4 1/3] dt-bindings: arm: qcom: Add Dell XPS 13 9345

Hello,

On Wed, 9 Oct 2024 at 08:55, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 08/10/2024 23:07, Stefan Schmidt wrote:
> > Hello Aleksandrs,
> >
> > [Again in plain text]
> >
> > On Thu, 3 Oct 2024 at 23:12, Aleksandrs Vinarskis
> > <alex.vinarskis@...il.com> wrote:
> >>
> >> Document the X1E80100-based Dell XPS 13 9345 laptop, platform
> >> codenamed 'Tributo'/'Tributo R'.
> >>
> >> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> ---
> >>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> >> index 5cb54d69af0b..7c01fe30dabc 100644
> >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> >> @@ -1058,6 +1058,7 @@ properties:
> >>        - items:
> >>            - enum:
> >>                - asus,vivobook-s15
> >> +              - dell,xps13-9345
> >>                - lenovo,yoga-slim7x
> >>                - microsoft,romulus13
> >>                - microsoft,romulus15
> >> --
> >> 2.43.0
> >
> > Tested-by: Stefan Schmidt <stefan.schmidt@...aro.org>
>
> How do you test bindings? Running static checks in kernel tree is the
> same as compiling software and adding tested-by.

I took the whole patchset in when testing it on the actual hardware,
so I gave the tested-by for the whole series as well.
That being said, the binding patch here does indeed not benefit from
any on device testing. Feel free to drop it.

regards
Stefan Schmidt