linux-kernel - Re: [RESEND PATCH v4 5/5] sysctl: delete six_hundred_forty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ebhtelo7eoonscepify6wbvca6s2zvnpyookcwzo3jzbqg44ke@5j4psffltsbl>
Date: Wed, 9 Oct 2024 10:58:59 +0200
From: Joel Granados <j.granados@...sung.com>
To: Wen Yang <wen.yang@...ux.dev>
CC: Luis Chamberlain <mcgrof@...nel.org>, Kees Cook <keescook@...omium.org>,
	"Eric W . Biederman" <ebiederm@...ssion.com>, Christian Brauner
	<brauner@...nel.org>, Thomas Weißschuh <thomas@...ch.de>,
	<linux-kernel@...r.kernel.org>, Dave Young <dyoung@...hat.com>,
	<joel.granados@...nel.org>
Subject: Re: [RESEND PATCH v4 5/5] sysctl: delete six_hundred_forty_kb to
 save 4 bytes

Hey 

I have the last version in line for review this week. I'll ignore this
"resend" as it is the same as the previous email.
FYI: I have moved to joel.granados@...nel.org. please send all sysctl
related stuff there, I might miss it if it lands here.

Best


On Tue, Oct 08, 2024 at 11:17:00PM +0800, Wen Yang wrote:
> By directly encoding specific numbers into the min/max field,
> unnecessary global variable six_hundred_forty_kb can be removed,
> saving 4 bytes
> 
> Signed-off-by: Wen Yang <wen.yang@...ux.dev>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Joel Granados <j.granados@...sung.com>
> Cc: Eric W. Biederman <ebiederm@...ssion.com>
> Cc: Christian Brauner <brauner@...nel.org>
> Cc: Dave Young <dyoung@...hat.com>
> Cc: linux-kernel@...r.kernel.org
> ---
>  kernel/sysctl.c | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)
> 
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 05197d46007d..c8460b5e0605 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -90,13 +90,6 @@ EXPORT_SYMBOL_GPL(sysctl_long_vals);
>  
>  #if defined(CONFIG_SYSCTL)
>  
> -/* Constants used for minimum and maximum */
> -
> -#ifdef CONFIG_PERF_EVENTS
> -static const int six_hundred_forty_kb = 640 * 1024;
> -#endif
> -
> -
>  static const int ngroups_max = NGROUPS_MAX;
>  static const int cap_last_cap = CAP_LAST_CAP;
>  
> @@ -1964,10 +1957,10 @@ static struct ctl_table kern_table[] = {
>  		.procname	= "perf_event_max_stack",
>  		.data		= &sysctl_perf_event_max_stack,
>  		.maxlen		= sizeof(sysctl_perf_event_max_stack),
> -		.mode		= 0644,
> +		.mode		= 0644 | SYSCTL_FLAG_MIN | SYSCTL_FLAG_MAX,
>  		.proc_handler	= perf_event_max_stack_handler,
> -		.extra1		= SYSCTL_ZERO,
> -		.extra2		= (void *)&six_hundred_forty_kb,
> +		.min		= 0,
> +		.max		= 640 * 1024,
>  	},
>  	{
>  		.procname	= "perf_event_max_contexts_per_stack",
> -- 
> 2.25.1
> 

-- 

Joel Granados