linux-kernel - Re: [PATCH v1] Coresight: Narrow down the matching range of tpdm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0525c2a9-45a5-4654-aaf4-b0ab9e161884@quicinc.com>
Date: Wed, 9 Oct 2024 17:20:26 +0800
From: songchai <quic_songchai@...cinc.com>
To: Suzuki K Poulose <suzuki.poulose@....com>,
        Mike Leach
	<mike.leach@...aro.org>, James Clark <james.clark@....com>,
        Alexander
 Shishkin <alexander.shishkin@...ux.intel.com>,
        Andy Gross
	<agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring
	<robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <coresight@...ts.linaro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v1] Coresight: Narrow down the matching range of tpdm


On 10/9/2024 4:54 PM, Suzuki K Poulose wrote:
> On 09/10/2024 09:50, Songwei Chai wrote:
>> The format of tpdm's peripheral id is 1f0exx. To avoid potential
>> conflicts in the future, update the .id_table's id to 0x001f0e00.
>> This update will narrow down the matching range and prevent incorrect
>> matches. For example, another component's peripheral id might be
>> f0e00, which would incorrectly match the old id.
>>
>> Signed-off-by: Songwei Chai <quic_songchai@...cinc.com>
>> ---
>>   drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c 
>> b/drivers/hwtracing/coresight/coresight-tpdm.c
>> index b7d99e91ab84..8e2985d17549 100644
>> --- a/drivers/hwtracing/coresight/coresight-tpdm.c
>> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
>> @@ -1308,8 +1308,8 @@ static void tpdm_remove(struct amba_device *adev)
>>    */
>>   static struct amba_id tpdm_ids[] = {
>>       {
>> -        .id = 0x000f0e00,
>> -        .mask = 0x000fff00,
>> +        .id = 0x001f0e00,
>> +        .mask = 0x00ffff00,
>>       },
>>       { 0, 0, NULL },
>>   };
>>
>
> Please could you add "Fixes" tag for this ? You don't want an old 
> kernel detect something else as TPDM, so this must go to stable kernels.
> Also, while at it, please could you intend the id and mask values with
> tabs, so it is easier to what exactly we are matching ? e.g,
Thanks for your quick response, Suzuki.
Corrected it in the new version!
>
>
>     .id    = 0x001f0e00,
>     .mask    = 0x00ffff00,
>
> Kind regards
> Suzuki
>
>