linux-kernel - Re: [PATCH v6 16/33] riscv/shstk: If needed allocate a new shadow stack on clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwZaG3NT72BwYxJO@finisterre.sirena.org.uk>
Date: Wed, 9 Oct 2024 11:25:31 +0100
From: Mark Brown <broonie@...nel.org>
To: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
Cc: "corbet@....net" <corbet@....net>, "robh@...nel.org" <robh@...nel.org>,
	"lorenzo.stoakes@...cle.com" <lorenzo.stoakes@...cle.com>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"debug@...osinc.com" <debug@...osinc.com>,
	"vbabka@...e.cz" <vbabka@...e.cz>,
	"brauner@...nel.org" <brauner@...nel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"palmer@...belt.com" <palmer@...belt.com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
	"Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
	"oleg@...hat.com" <oleg@...hat.com>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor@...nel.org" <conor@...nel.org>,
	"ebiederm@...ssion.com" <ebiederm@...ssion.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"arnd@...db.de" <arnd@...db.de>, "bp@...en8.de" <bp@...en8.de>,
	"kees@...nel.org" <kees@...nel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"shuah@...nel.org" <shuah@...nel.org>,
	"jim.shu@...ive.com" <jim.shu@...ive.com>,
	"alistair.francis@....com" <alistair.francis@....com>,
	"cleger@...osinc.com" <cleger@...osinc.com>,
	"kito.cheng@...ive.com" <kito.cheng@...ive.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"samitolvanen@...gle.com" <samitolvanen@...gle.com>,
	"evan@...osinc.com" <evan@...osinc.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"atishp@...osinc.com" <atishp@...osinc.com>,
	"andybnac@...il.com" <andybnac@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"charlie@...osinc.com" <charlie@...osinc.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"richard.henderson@...aro.org" <richard.henderson@...aro.org>,
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
	"alexghiti@...osinc.com" <alexghiti@...osinc.com>
Subject: Re: [PATCH v6 16/33] riscv/shstk: If needed allocate a new shadow
 stack on clone

On Tue, Oct 08, 2024 at 10:55:29PM +0000, Edgecombe, Rick P wrote:

> A lot of this patch and the previous one is similar to x86's and arm's. It great
> that we can have consistency around this behavior.

> There might be enough consistency to refactor some of the arch code into a
> kernel/shstk.c.

> Should we try?

I think so - I think we discussed it before.  I was thinking of looking
at it once the clone3() stuff settles down, I don't want to trigger any
unneeded refectorings there and cause further delays.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)