linux-kernel - Re: [PATCH V1 2/3] drivers/fpga/amd: Add communication with firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202410091855.yLTZGOfr-lkp@intel.com>
Date: Wed, 9 Oct 2024 18:44:51 +0800
From: kernel test robot <lkp@...el.com>
To: David Zhang <yidong.zhang@....com>, linux-kernel@...r.kernel.org,
	linux-fpga@...r.kernel.org, mdf@...nel.org, hao.wu@...el.com,
	yilun.xu@...el.com
Cc: oe-kbuild-all@...ts.linux.dev, Yidong Zhang <yidong.zhang@....com>,
	lizhi.hou@....com, Nishad Saraf <nishads@....com>,
	Prapul Krishnamurthy <prapulk@....com>
Subject: Re: [PATCH V1 2/3] drivers/fpga/amd: Add communication with firmware

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.12-rc2 next-20241008]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Zhang/drivers-fpga-amd-Add-communication-with-firmware/20241008-060253
base:   linus/master
patch link:    https://lore.kernel.org/r/20241007220128.3023169-2-yidong.zhang%40amd.com
patch subject: [PATCH V1 2/3] drivers/fpga/amd: Add communication with firmware
config: x86_64-randconfig-121-20241009 (https://download.01.org/0day-ci/archive/20241009/202410091855.yLTZGOfr-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241009/202410091855.yLTZGOfr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410091855.yLTZGOfr-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   drivers/fpga/amd/vmgmt.c:35:14: sparse: sparse: symbol 'vmgmt_class' was not declared. Should it be static?
>> drivers/fpga/amd/vmgmt.c:272:45: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void const [noderef] __user *from @@     got void * @@
   drivers/fpga/amd/vmgmt.c:272:45: sparse:     expected void const [noderef] __user *from
   drivers/fpga/amd/vmgmt.c:272:45: sparse:     got void *
   drivers/fpga/amd/vmgmt.c:301:45: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void const [noderef] __user *from @@     got void * @@
   drivers/fpga/amd/vmgmt.c:301:45: sparse:     expected void const [noderef] __user *from
   drivers/fpga/amd/vmgmt.c:301:45: sparse:     got void *

vim +272 drivers/fpga/amd/vmgmt.c

   257	
   258	static long vmgmt_ioctl(struct file *filep, unsigned int cmd, unsigned long arg)
   259	{
   260		struct vmgmt_device *vdev = (struct vmgmt_device *)filep->private_data;
   261		struct vmgmt_fpga_region reg = { 0 };
   262		struct fpga_region *region = NULL;
   263		struct axlf *axlf = NULL;
   264		void *data = NULL;
   265		size_t size = 0;
   266		int ret = 0;
   267	
   268		axlf = vmalloc(sizeof(*axlf));
   269		if (!axlf)
   270			return -ENOMEM;
   271	
 > 272		ret = copy_from_user((void *)axlf, (void *)arg, sizeof(*axlf));
   273		if (ret) {
   274			vmgmt_err(vdev, "Failed to copy axlf: %d", ret);
   275			ret = -EFAULT;
   276			goto exit;
   277		}
   278	
   279		ret = memcmp(axlf->magic, VERSAL_XCLBIN_MAGIC_ID,
   280			     sizeof(VERSAL_XCLBIN_MAGIC_ID));
   281		if (ret) {
   282			vmgmt_err(vdev, "unknown axlf magic %s", axlf->magic);
   283			ret = -EINVAL;
   284			goto exit;
   285		}
   286	
   287		/* axlf should never be over 1G and less than size of struct axlf */
   288		size = axlf->header.length;
   289		if (size < sizeof(struct axlf) || size > 1024 * 1024 * 1024) {
   290			vmgmt_err(vdev, "axlf length %zu is invalid", size);
   291			ret = -EINVAL;
   292			goto exit;
   293		}
   294	
   295		data = vmalloc(size);
   296		if (!data) {
   297			ret = -ENOMEM;
   298			goto exit;
   299		}
   300	
   301		ret = copy_from_user((void *)data, (void *)arg, size);
   302		if (ret) {
   303			vmgmt_err(vdev, "Failed to copy data: %d", ret);
   304			ret = -EFAULT;
   305			goto exit;
   306		}
   307	
   308		switch (cmd) {
   309		case VERSAL_MGMT_LOAD_XCLBIN_IOCTL:
   310			vdev->fdev->fw.opcode = RM_QUEUE_OP_LOAD_XCLBIN;
   311			break;
   312		default:
   313			vmgmt_err(vdev, "Invalid IOCTL command: %d", cmd);
   314			ret = -EINVAL;
   315			goto exit;
   316		}
   317	
   318		reg.uuid = &axlf->header.rom_uuid;
   319		reg.fdev = vdev->fdev;
   320	
   321		region = fpga_region_class_find(NULL, &reg, vmgmt_fpga_region_match);
   322		if (!region) {
   323			vmgmt_err(vdev, "Failed to find compatible region");
   324			ret = -ENOENT;
   325			goto exit;
   326		}
   327	
   328		ret = vmgmt_region_program(region, data);
   329		if (ret) {
   330			vmgmt_err(vdev, "Failed to program region");
   331			goto exit;
   332		}
   333	
   334		vmgmt_info(vdev, "Downloaded axlf %pUb of size %zu Bytes",
   335			   &axlf->header.uuid, size);
   336		uuid_copy(&vdev->xclbin_uuid, &axlf->header.uuid);
   337	
   338	exit:
   339		vfree(data);
   340		vfree(axlf);
   341	
   342		return ret;
   343	}
   344	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki