linux-kernel - Re:[PATCH drm-dp 1/4] drm/hisilicon/hibmc: add dp aux in hibmc drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c25d1f.1954.1926eeca432.Coremail.andyshrk@163.com>
Date: Wed, 9 Oct 2024 09:37:35 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: shiyongbang <shiyongbang@...wei.com>
Cc: xinliang.liu@...aro.org, tiantao6@...ilicon.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, 
	tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch, 
	kong.kongxinwei@...ilicon.com, liangjian010@...wei.com, 
	chenjianmin@...wei.com, lidongming5@...wei.com, libaihan@...wei.com, 
	shenjian15@...wei.com, shaojijie@...wei.com, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re:[PATCH drm-dp 1/4] drm/hisilicon/hibmc: add dp aux in hibmc
 drivers


Hi Baihan，

At 2024-10-01 15:26:23, "shiyongbang" <shiyongbang@...wei.com> wrote:
>From: baihan li <libaihan@...wei.com>
>
>Add dp aux read/write functions. They are basic functions
> and will be used later.
>
>Signed-off-by: baihan li <libaihan@...wei.com>
>---
> drivers/gpu/drm/hisilicon/hibmc/Makefile     |   3 +-
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c  | 227 +++++++++++++++++++
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.h  |  80 +++++++
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h |  88 +++++++
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_reg.h  |  76 +++++++
> 5 files changed, 473 insertions(+), 1 deletion(-)
> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c
> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.h
> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h
> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/dp/dp_reg.h
>
>diff --git a/drivers/gpu/drm/hisilicon/hibmc/Makefile b/drivers/gpu/drm/hisilicon/hibmc/Makefile
>index d25c75e60d3d..8770ec6dfffd 100644
>--- a/drivers/gpu/drm/hisilicon/hibmc/Makefile
>+++ b/drivers/gpu/drm/hisilicon/hibmc/Makefile
>@@ -1,4 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0-only
>-hibmc-drm-y := hibmc_drm_drv.o hibmc_drm_de.o hibmc_drm_vdac.o hibmc_drm_i2c.o
>+hibmc-drm-y := hibmc_drm_drv.o hibmc_drm_de.o hibmc_drm_vdac.o hibmc_drm_i2c.o \
>+	       dp/dp_aux.o

>+
>+#define DPCD_LINK_BW_SET		0x0100
>+#define DPCD_LANE_COUNT_SET		0x0101
>+#define DPCD_TRAINING_PATTERN_SET	0x0102
>+#define DPCD_TRAINING_LANE0_SET		0x0103
>+#define DPCD_DOWNSPREAD_CTRL		0x0107
>+#define DPCD_LANE0_1_STATUS		0x0202
>+#define DPCD_ADJUST_REQUEST_LANE0_1	0x0206

It seems that all of these have been defined in this header file.
 include/drm/display/drm_dp.h：
DP_LINK_BW_SET
DP_LANE_COUNT_SET




>+
>+#define DPCD_VOLTAGE_SWING_LANE_0	(BIT(0) | BIT(1))
>+#define DPCD_PRE_EMPHASIS_LANE_0	(BIT(2) | BIT(3))
>+#define DPCD_VOLTAGE_SWING_SET_S	0
>+#define DPCD_PRE_EMPHASIS_SET_S		3
>+#define DPCD_SCRAMBLING_DISABLE		BIT(5)
>+#define DPCD_CR_DONE_BITS		BIT(0)
>+#define DPCD_EQ_DONE_BITS		(BIT(0) | BIT(1) | BIT(2))
>+#define DPCD_ENHANCED_FRAME_EN		0x80
>+
>+#define DPCD_TRAINING_PATTERN_DISABLE	0x0
>+#define DPCD_TRAINING_PATTERN_1		0x1
>+#define DPCD_TRAINING_PATTERN_2		0x2
>+#define DPCD_TRAINING_PATTERN_3		0x3
>+#define DPCD_TRAINING_PATTERN_4		0x7
>+#define DPCD_VOLTAGE_SWING_LEVEL_0	FIELD_PREP(GENMASK(1, 0), 0)
>+#define DPCD_VOLTAGE_SWING_LEVEL_1	FIELD_PREP(GENMASK(1, 0), 1)
>+#define DPCD_VOLTAGE_SWING_LEVEL_2	FIELD_PREP(GENMASK(1, 0), 2)
>+#define DPCD_VOLTAGE_SWING_LEVEL_3	FIELD_PREP(GENMASK(1, 0), 3)
>+#define DPCD_PRE_EMPHASIS_LEVEL_0	FIELD_PREP(GENMASK(4, 3), 0)
>+#define DPCD_PRE_EMPHASIS_LEVEL_1	FIELD_PREP(GENMASK(4, 3), 1)
>+#define DPCD_PRE_EMPHASIS_LEVEL_2	FIELD_PREP(GENMASK(4, 3), 2)
>+#define DPCD_PRE_EMPHASIS_LEVEL_3	FIELD_PREP(GENMASK(4, 3), 3)
>+
>+#define DP_LINK_RATE_NUM		4
>+#define DP_LINK_RATE_0			0x6
>+#define DP_LINK_RATE_1			0xA
>+#define DP_LINK_RATE_2			0x14
>+#define DP_LINK_RATE_3			0x1E
>+#define DP_AUX_NATIVE_REPLY_MASK	(0x3 << 4)
>+#define DP_AUX_ACK			(0 << 4)
>+#define DP_AUX_NACK			(0x1 << 4)
>+#define DP_AUX_DEFER			(0x2 << 4)
>+#define DP_CFG_AUX_S			17
>+#define DP_CFG_AUX_STATUS_S		4
>+
>+#define AUX_4_BYTE			4
>+#define AUX_4_BIT			4
>+#define AUX_8_BIT			8
>+#define AUX_RESET_INTERVAL		15
>+#define AUX_RETRY_INTERVAL		500
>+#define AUX_READY_DATA_BYTE_S		12
>+
>+/* aux_cmd_addr register shift */
>+#define AUX_CMD_REQ_TYPE_S		0
>+#define AUX_CMD_REQ_LEN_S		4
>+#define AUX_CMD_ADDR_S			8
>+#define AUX_CMD_I2C_ADDR_ONLY_S		28
>