[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdbqPMb7MSnEeK4vADrfeZD=dk6GA=A_i2M-53eGmJkTag@mail.gmail.com>
Date: Wed, 9 Oct 2024 13:36:03 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Théo Lebrun <theo.lebrun@...tlin.com>
Cc: Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
Grégory Clement <gregory.clement@...tlin.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Tawfik Bayouk <tawfik.bayouk@...ileye.com>
Subject: Re: [PATCH v2 6/6] i2c: nomadik: support >=1MHz speed modes
On Wed, Oct 9, 2024 at 12:23 PM Théo Lebrun <theo.lebrun@...tlin.com> wrote:
> - BRCR value must go into the BRCR1 field when in high-speed mode.
> It goes into BRCR2 otherwise.
>
> - Remove fallback to standard mode if priv->sm > I2C_FREQ_MODE_FAST.
>
> - Set SM properly in probe; previously it only checked STANDARD versus
> FAST. Now we set STANDARD, FAST, FAST_PLUS or HIGH_SPEED.
>
> - Remove all comment sections saying we only support low-speeds.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Yours,
Linus Walleij
Powered by blists - more mailing lists