linux-kernel - Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwZuTWspV54Pn0GN@linaro.org>
Date: Wed, 9 Oct 2024 14:51:41 +0300
From: Abel Vesa <abel.vesa@...aro.org>
To: Pengfei Li <pengfei.li_1@....com>
Cc: krzk+dt@...nel.org, robh@...nel.org, abelvesa@...nel.org,
	mturquette@...libre.com, sboyd@...nel.org, conor+dt@...nel.org,
	shawnguo@...nel.org, s.hauer@...gutronix.de, ping.bai@....com,
	ye.li@....com, peng.fan@....com, aisheng.dong@....com,
	frank.li@....com, kernel@...gutronix.de, festevam@...il.com,
	linux-clk@...r.kernel.org, imx@...ts.linux.dev,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

On 24-06-27 16:24:25, Pengfei Li wrote:
> IMX93_CLK_END was previously defined in imx93-clock.h to indicate
> the number of clocks, but it is not part of the ABI, so it should
> be moved to clk driver.
> 
> Signed-off-by: Pengfei Li <pengfei.li_1@....com>
> ---
> 
> Notes:
>     Change for v2:
>     - Use pre-processor define to simplify code.
> 
>  drivers/clk/imx/clk-imx93.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
> index c6a9bc8ecc1f..c8b65146e76e 100644
> --- a/drivers/clk/imx/clk-imx93.c
> +++ b/drivers/clk/imx/clk-imx93.c
> @@ -15,6 +15,8 @@
>  
>  #include "clk.h"
>  
> +#define IMX93_CLK_END 202
> +

TBH, I don't like this. And I still don't understand the reason.

Where are the clocks you want to add ?

And why wouldn't it be OK to just keep this in the bindings header even
if you need to add more clocks ?

For the moment, I don't see the value of this change.

Sorry, but NACK.

>  enum clk_sel {
>  	LOW_SPEED_IO_SEL,
>  	NON_IO_SEL,
> -- 
> 2.34.1
>